Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for ComponentEditor #730

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Conversation

jwiggins
Copy link
Member

Closes #627

@aaronayres35 aaronayres35 self-requested a review March 19, 2021 12:15
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just one comment and the following question:

The issue also mentions "the rgba_trait and the RBAColorEditor, and other relevant TraitsUI facilities (possibly the font editor from Kiva and the editors from Savage...". Are we planning to touch on any of these, as the PR description says this closes 627

@jwiggins
Copy link
Member Author

I think RGBAColor and its editor is essentially dead code.

@jwiggins
Copy link
Member Author

Thanks for the feedback.

@jwiggins jwiggins merged commit 16d110a into master Mar 19, 2021
@jwiggins jwiggins deleted the docs/component-editor branch March 19, 2021 15:50
jwiggins added a commit that referenced this pull request Mar 24, 2021
jwiggins added a commit that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable: document ComponentEditor and other TraitsUI facilities
2 participants