Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on ubuntu-18.04, not 16.04 #889

Merged
merged 5 commits into from
Nov 9, 2021
+3 −3
Merged

Test on ubuntu-18.04, not 16.04 #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce68953
FIX : Test on ubuntu-18.04, not 16.04
Nov 8, 2021
9c0b107
FIX : Use ubuntu-latest instead of ubuntu-18.04
Nov 8, 2021
4002653
FIX : Use ubuntu-18.04 with the right package repository
Nov 8, 2021
bbb8eef
FIX : Install libsdl2-dev using the ubuntu package manager
Nov 8, 2021
c2b2420
FIX : Use libsdl1.2, not libsdl2
Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-with-edm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
toolkit: ['null', 'pyqt5', 'pyside2', 'wx']
runs-on: ubuntu-16.04
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2
- name: Install Qt dependencies for Linux
Expand All @@ -27,7 +27,7 @@ jobs:
- name: Install Wx dependencies for Linux
run: |
sudo apt-get update
sudo apt-get install libsdl2-2.0-0
sudo apt-get install libsdl1.2-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice there was an old open and closed PR #865 that I believe was closed because of wx failures.

Are those still present if we try to use ubuntu-latest - hence the use of 18.04 in this PR instead? Does this wx dependency change have any impact on those failures?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: looks like in the commit history on this PR you tried ubuntu-latest, then came back - so I'm assuming latest still has some issues and that is a can of worms for a future day

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those still present if we try to use ubuntu-latest

I haven't tested with ubuntu-latest (ubuntu-20.04 at the moment)

Does this wx dependency change have any impact on those failures?

I'm not sure. I didn't investigate it further.

so I'm assuming latest still has some issues

No. I realized that I made a mistake when using ubuntu-18.04, which is why i reverted the change to ubuntu-latest. I will investigate later what happens when we use ubuntu-latest.

if: matrix.toolkit == 'wx'
- name: Install GL dependencies for Linux
run: sudo apt-get install libglu1-mesa-dev
Expand Down
2 changes: 1 addition & 1 deletion ci/edmtool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def install(runtime, toolkit, environment, source):
elif sys.platform == "linux":
# XXX this is mainly for TravisCI workers; need a generic solution
commands.append(
"edm run -e {environment} -- pip install -f https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-16.04/ wxPython<4.1" # noqa: E501
"edm run -e {environment} -- pip install -f https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-18.04/ wxPython<4.1" # noqa: E501
)
else:
commands.append(
Expand Down