Improve font weight parsing #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the following changes: - corrects the font weight constants to match the OpenType values - where possible, gets the font weight, stetch and slope from OS/2 data table - adjusts the way FontEntry values are computed to account for these changes - allows font entry weights which are not multiples of 100, but restricts them to range of 100 to 1000 - bumps the font database version number to force a recompute
Merged
rkern
approved these changes
Mar 25, 2022
| break | ||
| # We prefer weight values from the OS/2 table, if available, otherwise | ||
| # infer from the "name" table's style | ||
| weight = props.get("weight") | ||
| if not weight: |
There was a problem hiding this comment.
I'm pretty sure this was meant to be if weight is None:, just with the bad habits of years past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following changes:
This fixes #908.