Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Use correct path to the default font #931

Merged
merged 2 commits into from
Apr 20, 2022
Merged

FIX: Use correct path to the default font #931

merged 2 commits into from
Apr 20, 2022

Conversation

ffishburn
Copy link
Contributor

Closes #930. Fixes a typo in the default font filename

jwiggins
jwiggins reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye. Can you add a unit test which actually exercises this code path?

@corranwebster
Copy link
Contributor

I am adding tests for this - most of the machinery is already in the test suite so it's fairly straighforward.

corranwebster
corranwebster approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the fix, but since I wrote the tests it might make sense to have another set of eyes on my contribution.

jwiggins
jwiggins approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the test coverage.

@corranwebster corranwebster merged commit 129299b into main Apr 20, 2022
@jwiggins jwiggins deleted the fix/fallback-font branch April 20, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

@jwiggins jwiggins jwiggins approved these changes

@aaronayres35 aaronayres35 Awaiting requested review from aaronayres35

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling Font.findfont results in RecursionError if no fonts are installed on the system
3 participants
@ffishburn @corranwebster @jwiggins