Add a flake8 command to etstool.py #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also adds a setup.cfg which makes flake8 run cleanly. There are things in the clean list that are likely errors and need to be fixed. This doesn't add flake8 to CI, that should be a separate PR.
rahulporuri
reviewed
Sep 28, 2021
| parameters = get_parameters(edm, runtime, toolkit, environment) | ||
| config = "" | ||
| if strict: | ||
| config = "--config=flake8_strict.cfg " |
There was a problem hiding this comment.
I'm not sure what this file is. should this be setup.cfg?
Also, I don't fully understand what the point of "strict" vs "non-strict" options for flake8 is - don't we always want to use "strict"?
There was a problem hiding this comment.
This is a copy-pasta from TraitsUI - the idea was strict is something like what we are aiming for (and so new code should pass strict), but there are a lot of issues that need fixing before old code could pass the strict version.
There was a problem hiding this comment.
Obviously I'll fix one way or another.
rahulporuri
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds a setup.cfg which makes flake8 run cleanly. There are
things in the clean list that are likely errors and need to be fixed.
This doesn't add flake8 to CI, that should be a separate PR.