Add temporary pin for PySide6 version #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Nov 7, 2022
| @@ -214,11 +214,13 @@ def install(edm, runtime, toolkit, environment, editable, source): | |||
| elif toolkit == "pyside6": | |||
| if sys.platform == 'darwin': | |||
| commands.append( | |||
| "{edm} run -e {environment} -- pip install pyside6<6.2.2'" | |||
| "{edm} run -e {environment} -- pip install pyside6<6.2.2" | |||
There was a problem hiding this comment.
Drive-by fix to remove a spurious quote.
|
@corranwebster I'm running into quoting issues on Windows. Any suggestions about how to fix? |
No. I ended up just skipping the EDM Windows/PySide6 combination in CI for the equivalent PR in TraitsUI. I think it might be fixable by refactoring etstool to pass lists of strings that form a command, rather than a single string, but I didn't have time to do that. In general the etstools need a bit of a refactor, particularly given the improvements in pip and other related tooling. |
|
Looks like I've finally found the right combination. |
corranwebster
approved these changes
Nov 7, 2022
corranwebster
added
the
needs backport to maint/*
corranwebster
pushed a commit
that referenced
this pull request
Nov 11, 2022
Add temporary pin for PySide6 version
corranwebster
pushed a commit
that referenced
this pull request
Nov 14, 2022
Add temporary pin for PySide6 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily pins the PySide6 version in CI, to give us breathing space to adapt to the backwards-incompatible Enum-related changes introduced in PySide6 6.4.0.