Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary pin for PySide6 version #1169

Merged
merged 9 commits into from
Nov 7, 2022
Merged

Add temporary pin for PySide6 version #1169

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5fe5f1a
Add temporary pin for PySide6 version
mdickinson Nov 7, 2022
6ba81e7
Revert the change while we investigate other CI issues
mdickinson Nov 7, 2022
9a634d2
Add quotes
mdickinson Nov 7, 2022
185d03f
Only quote on Windows
mdickinson Nov 7, 2022
3aca570
Try removing quotes again
mdickinson Nov 7, 2022
b89aac5
Try double quotes
mdickinson Nov 7, 2022
39751c0
Add spaces to prevent the < being interpreted as a redirection operator
mdickinson Nov 7, 2022
0602779
Don't split on the spaces
mdickinson Nov 7, 2022
082f204
Try removing the quotes
mdickinson Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions etstool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,13 @@ def install(edm, runtime, toolkit, environment, editable, source):
elif toolkit == "pyside6":
if sys.platform == 'darwin':
commands.append(
"{edm} run -e {environment} -- pip install pyside6<6.2.2'"
"{edm} run -e {environment} -- pip install pyside6<6.2.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix to remove a spurious quote.

)
else:
# PySide6 6.4 has some backwards-incompatible changes to Enums
# that we haven't updated for yet. xref: enthought/pyface#1164
commands.append(
"{edm} run -e {environment} -- pip install pyside6"
"{edm} run -e {environment} -- pip install 'pyside6<6.4'"
)
commands.append(
"{edm} run -e {environment} -- pip install pillow"
Expand Down