Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont include ALL txt files from root directory #816

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Conversation

rahulporuri
Copy link
Contributor

This PR changes the manifest file to only include the image license and other relevant top level files, not all txt extension files.

On master, the following additional files are included in the sdist, which aren't included in this PR.

  • appveyor-clean-cache.txt
  • CHANGES.txt
  • ci-src-requirements.txt
  • dev_requirements.txt
  • doc-src-requirements.txt

only include the image license and other relevant top level files

	modified:   MANIFEST.in
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #816 (1cecfe4) into master (0d1516e) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   40.81%   40.89%   +0.07%     
==========================================
  Files         508      508              
  Lines       27845    27847       +2     
  Branches     4219     4219              
==========================================
+ Hits        11366    11388      +22     
+ Misses      15999    15986      -13     
+ Partials      480      473       -7     
Impacted Files Coverage Δ
pyface/ui/wx/tree/tree.py 0.00% <ø> (ø)
pyface/i_widget.py 100.00% <100.00%> (ø)
pyface/ui/qt4/console/console_widget.py 29.28% <0.00%> (+0.20%) ⬆️
pyface/ui/qt4/code_editor/code_widget.py 43.97% <0.00%> (+0.42%) ⬆️
pyface/wx/python_stc.py 10.36% <0.00%> (+1.21%) ⬆️
pyface/ui/wx/window.py 77.10% <0.00%> (+2.40%) ⬆️
pyface/ui/qt4/util/gui_test_assistant.py 80.53% <0.00%> (+2.65%) ⬆️
pyface/ui/wx/data_view/data_view_widget.py 77.52% <0.00%> (+5.61%) ⬆️
pyface/__init__.py 88.88% <0.00%> (+7.40%) ⬆️
pyface/i_file_dialog.py 84.61% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4751783...1cecfe4. Read the comment docs.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 05ef91c into master Nov 27, 2020
@rahulporuri rahulporuri deleted the fix/manifest branch November 27, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants