Catch deprecation warning thrown by QtScript import in testsuite #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyface.qt.QtScript is expected to throw a deprecation warning on PyQt5/PySide2, which the new test checks, while also swallowing the deprecation warning and making the test output cleaner. modified: pyface/ui/qt4/tests/test_qt_imports.py
aaronayres35
approved these changes
Jul 7, 2021
I think so. We'll cross that bridge when we finally start removing support for PyQt4 from the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyface.qt.QtScriptis expected to throw a deprecation warning onPyQt5/PySide2. We refactored the existing test to create a new test that checks for the deprecation warning while also swallowing the deprecation warning thereby making the test output cleaner.fixes #582 (the last open item)