SplitWidget fixes #977
Merged
SplitWidget fixes #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clean up of traits (including adding an "Orientation" trait) - deprecate automatic creation of widgets in __init__ - general clean-up
rahulporuri
approved these changes
Jul 13, 2021
Comment on lines
+37
to
+42
| warnings.warn( | ||
| "automatic widget creation is deprecated and will be removed " | ||
| "in a future Pyface version, use create=False and explicitly " | ||
| "call create() for future behaviour", | ||
| PendingDeprecationWarning, | ||
| ) |
There was a problem hiding this comment.
same comment here regarding an issue to handle this deprecation - looks like a single issue will suffice to handle all such deprecations related to the create method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to the
SplitWidgetclass and related classes (particularlySplitPanel)SplitPanel.__init__(part of The _create method should be public #729)Orientationtrait and use it where applicable