Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function to compute some minimal unsatisfiable subsets #219

Merged
merged 6 commits into from
May 27, 2016
Merged

Function to compute some minimal unsatisfiable subsets #219

merged 6 commits into from
May 27, 2016

Conversation

cournape
Copy link
Contributor

@cournape cournape added this to the 0.4.0 milestone May 26, 2016
noraderam
noraderam reviewed May 26, 2016
View reviewed changes
simplesat/dependency_solver.py
unsatisfiable subset of the original set of clauses.

Proof: If some proper subset C of A* U B* is UNSAT, then there is some
clause c in A* U B* not in C. If c is in A*, then that means (A* - {c}) U
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the use of c here confusing--I initially read this as c \in C. Could you use a different letter?

@noraderam
Copy link
Contributor

Can you give an example of a minimal set with more than two elements?

@noraderam
Copy link
Contributor

Can you give an example of a minimal set with more than two elements?

There are certainly simpler answers, but here's what I came up with:

        A 1.0-1; provides (X)
        B 1.0-1; provides (X, Y, Z)
        C 1.0-1; provides (Y)
        D 1.0-1; provides (Y, Z)
        P 1.0-1; depends (X)
        Q 1.0-1; depends (Y); conflicts (A ^= 1.0)
        R 1.0-1; depends (Z); conflicts (B ^= 1.0)

        requirements = [
            Requirement._from_string("P"),
            Requirement._from_string("Q"),
            Requirement._from_string("R"),

P, Q, R is a minimal unsatisfiable set

I think it would be worthwhile to include a test for a case like this

@noraderam noraderam assigned cournape and unassigned noraderam May 26, 2016
@cournape cournape assigned noraderam and unassigned cournape May 26, 2016
@cournape
Copy link
Contributor Author

@noraderam how does that look now ?

@noraderam
Copy link
Contributor

LGTM

@noraderam noraderam assigned cournape and unassigned noraderam May 26, 2016
@cournape cournape merged commit 80032a0 into master May 27, 2016
@cournape cournape deleted the feat/min-unsat branch May 27, 2016 09:55
cournape added a commit that referenced this pull request May 27, 2016
@cournape
Merge pull request #219 from enthought/feat/min-unsat
86c94ad 
Function to compute some minimal unsatisfiable subsets
(cherry picked from commit 80032a0)
cournape added a commit that referenced this pull request May 27, 2016
@cournape
Merge pull request #222 from enthought/backport/pr-219
0dde20b 
Merge pull request #219 from enthought/feat/min-unsat
This was referenced Jun 22, 2016
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cournape cournape

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cournape @noraderam