Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hard-code class names in __repr__ implementations #1335

Merged
merged 8 commits into from
Nov 4, 2020
Merged

Don't hard-code class names in __repr__ implementations #1335

merged 8 commits into from
Nov 4, 2020

Commits on Nov 2, 2020

  1. use self.__class__.__name__ instead of hardcoding class names when ov… 

    …erriding __repr__
    @aaronayres35
    aaronayres35 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    6f90dd5 View commit details
    Browse the repository at this point in the history

  2. adding trivial tests for the reprs

    @aaronayres35
    aaronayres35 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    129d2b5 View commit details
    Browse the repository at this point in the history

  3. making test not so hardcoded so that it still passes on CI

    @aaronayres35
    aaronayres35 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    ffdbe80 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. using f strings and capitalizing docstrings

    @aaronayres35
    aaronayres35 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    ed308c6 View commit details
    Browse the repository at this point in the history

  2. adding tests for subclass reprs

    @aaronayres35
    aaronayres35 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    f8038b9 View commit details
    Browse the repository at this point in the history

  3. one more subclass repr test

    @aaronayres35
    aaronayres35 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    fbc56cb View commit details
    Browse the repository at this point in the history

  4. updating _something_changed_event reprs to also use f strings

    @aaronayres35
    aaronayres35 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    770e3d3 View commit details
    Browse the repository at this point in the history

  5. flake8 / use fstring in test

    @aaronayres35
    aaronayres35 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    f7492c6 View commit details
    Browse the repository at this point in the history