Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo application HTML view is not getting a base_url #804

Closed
corranwebster opened this issue May 5, 2020 · 1 comment · Fixed by #850
Closed

Demo application HTML view is not getting a base_url #804

corranwebster opened this issue May 5, 2020 · 1 comment · Fixed by #850
Assignees
@kitchoi
Milestone
Release 7.0.1

Comments

@corranwebster
Copy link
Contributor

This means links to images, etc. aren't working.
@kitchoi kitchoi mentioned this issue May 13, 2020
Merged
@corranwebster corranwebster added this to the Release 7.0.1 milestone May 20, 2020
@kitchoi kitchoi self-assigned this May 28, 2020
@kitchoi
Copy link
Contributor

kitchoi commented May 28, 2020

#808 has added the base_url to the various HTMLEditor.

From #808:

It doesn't totally fix #804. It should display the image if it is present. It doesn't fix the hard-coded name.

I believe the remaining issue here is that one may get a broken image if the hard-coded "traits_ui_demo.jpg" file does not exist.

@kitchoi kitchoi mentioned this issue May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitchoi kitchoi

Labels
None yet
Projects
None yet
Milestone
Release 7.0.1
2 participants
@corranwebster @kitchoi