explicitly install swig 3.0.12 for cron job #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronayres35
commented
May 7, 2021
Comment on lines
7
to
9
| on: pull_request | ||
| #schedule: | ||
| # - cron: '0 0 * * 4' |
There was a problem hiding this comment.
Will revert this before merging. Needed to verify the changes made
Still using swig 4, i still need to look into this more |
rahulporuri
approved these changes
May 10, 2021
Comment on lines
+15
to
+16
| # Note that Ubuntu 20 cannot be used because its SWIG version is 4.0 | ||
| # (enthought/enable#360) |
There was a problem hiding this comment.
i'd be surprised if we can't explicitly install swig 3 on ubuntu 20
There was a problem hiding this comment.
I felt the same way but struggled a bit to do so and then saw this from enable so just copied it here. I will look into this more to try and get swig 3 on ubuntu 20.
There was a problem hiding this comment.
I am going to push this through and open a follow up issue
There was a problem hiding this comment.
I've opened #1660
aaronayres35
added a commit
that referenced
this pull request
May 11, 2021
* explicitly install swig 3.0.12 * new command is ubuntu specific * typo * follow enables lead * missed an ubuntu-latest * keep mattrix os and runs on in sync * go back to scheduled not on pull request
aaronayres35
added a commit
that referenced
this pull request
May 11, 2021
* skip a couple wx test failures (#1656) * skip test failing on wx * skip failing button editor test on wx * update changelog with backports * explicitly install swig 3.0.12 for cron job (#1652) * explicitly install swig 3.0.12 * new command is ubuntu specific * typo * follow enables lead * missed an ubuntu-latest * keep mattrix os and runs on in sync * go back to scheduled not on pull request
aaronayres35
added a commit
that referenced
this pull request
May 11, 2021
* skip a couple wx test failures (#1656) * skip test failing on wx * skip failing button editor test on wx * update changelog with backports * explicitly install swig 3.0.12 for cron job (#1652) * explicitly install swig 3.0.12 * new command is ubuntu specific * typo * follow enables lead * missed an ubuntu-latest * keep mattrix os and runs on in sync * go back to scheduled not on pull request
aaronayres35
added a commit
that referenced
this pull request
May 12, 2021
* Backport recent PRs and update changelog for 7.2.0 (#1661) * skip a couple wx test failures (#1656) * skip test failing on wx * skip failing button editor test on wx * update changelog with backports * explicitly install swig 3.0.12 for cron job (#1652) * explicitly install swig 3.0.12 * new command is ubuntu specific * typo * follow enables lead * missed an ubuntu-latest * keep mattrix os and runs on in sync * go back to scheduled not on pull request * specify we require traits 6.2+ and pyface 7.2+
aaronayres35
added a commit
that referenced
this pull request
May 12, 2021
* Backport recent PRs and update changelog for 7.2.0 (#1661) * skip a couple wx test failures (#1656) * skip test failing on wx * skip failing button editor test on wx * update changelog with backports * explicitly install swig 3.0.12 for cron job (#1652) * explicitly install swig 3.0.12 * new command is ubuntu specific * typo * follow enables lead * missed an ubuntu-latest * keep mattrix os and runs on in sync * go back to scheduled not on pull request * specify we require traits 6.2+ and pyface 7.2+
aaronayres35
added a commit
that referenced
this pull request
May 12, 2021
* explicitly require traits 6.2 and pyface 7.2 (#1666) * Update changelog to match maint/7.2 (#1665) * Backport recent PRs and update changelog for 7.2.0 (#1661) * skip a couple wx test failures (#1656) * skip test failing on wx * skip failing button editor test on wx * update changelog with backports * explicitly install swig 3.0.12 for cron job (#1652) * explicitly install swig 3.0.12 * new command is ubuntu specific * typo * follow enables lead * missed an ubuntu-latest * keep mattrix os and runs on in sync * go back to scheduled not on pull request * specify we require traits 6.2+ and pyface 7.2+ * update changelog to include 1666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to the failing cron job https://github.com/enthought/traitsui/runs/2514003659?check_suite_focus=true
I believe failure was a result of enthought/enable#360
This PR explicitly installs swig 3.0.12 before trying to run testsEDIT: I now follow the lead of this comment / PR https://github.com/enthought/enable/pull/637/files#r583560231by running the tests on ubuntu 18 not 20 which defaults to the old swig
Checklist