Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require traits 6.2 and pyface 7.2 #1666

Merged
merged 1 commit into from
May 12, 2021

Conversation

aaronayres35
Copy link
Contributor

This was accidentally missed before the release. With recent changes TraitsUI now rquires newer Traits and Pyface.

These are a result of using Property(observe=...) and from pyface.undo.api import ...
Checklist
- [ ] Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

@aaronayres35 aaronayres35 requested a review from rahulporuri May 12, 2021 01:29
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 344e542 into master May 12, 2021
@aaronayres35 aaronayres35 deleted the require-correct-traits-pyface branch May 12, 2021 01:34
aaronayres35 added a commit that referenced this pull request May 12, 2021
* explicitly require traits 6.2 and pyface 7.2 (#1666)

* Update changelog to match maint/7.2 (#1665)

* Backport recent PRs and update changelog for 7.2.0 (#1661)

* skip a couple wx test failures (#1656)

* skip test failing on wx

* skip failing button editor test on wx

* update changelog with backports

* explicitly install swig 3.0.12 for cron job (#1652)

* explicitly install swig 3.0.12

* new command is ubuntu specific

* typo

* follow enables lead

* missed an ubuntu-latest

* keep mattrix os and runs on in sync

* go back to scheduled not on  pull request

* specify we require traits 6.2+ and pyface 7.2+

* update changelog to include 1666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants