Backport bug fix to 7.0.1 #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a test for #790 (they are now passing with traits 6.0 and 6.1) * Add two failing tests for #983 * Revert "Move format_func, format_str and invalid traits from factory to editor (#859)" This reverts commit 0617cea. * Skip the test that will fail on traits<6.1.0 after reverting #859. Test should pass with traits >= 6.1.0 * Fix a comment in tests
rahulporuri
approved these changes
Jul 10, 2020
| @@ -21,8 +21,6 @@ Fixes | |||
| (#848) | |||
| * Fix demo application description (#850) | |||
| * Fix auto-add functionality in ListStrModel (#860) | |||
| * Move format_func, format_str and invalid traits from factory to editor | |||
| (#859, #900) | |||
There was a problem hiding this comment.
That's right.
The issue fixed by #900 was directly caused by #859 though. With #859 reverted, #900 isn't fixing anything visible to the users. We did not need to revert #900 either, because the change there can stay in its own right (it is correcting a function signature trying to ducktype the editor class's __init__).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Note that this is targeting the
maint/7.0branch.