git: Write an envoy-mobile specific prepush bootstrap script #185
Labels
Milestone
Comments
buildbreaker
changed the title
buildbreaker
pushed a commit
that referenced
this issue
Jun 27, 2019
#185 Signed-off-by: Alan Chiu <achiu@lyft.com>
buildbreaker
pushed a commit
that referenced
this issue
Jun 28, 2019
#185 Removing the instructions for installing the envoy bootstrap since we will want to have our own. Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Remove envoy bootstrap install from docs Risk Level: low Testing: na Docs Changes: CONTRIBUTING.md Release Notes: [Optional Fixes #Issue] [Optional Deprecated:]
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this issue
Nov 28, 2022
envoyproxy/envoy-mobile#185 Removing the instructions for installing the envoy bootstrap since we will want to have our own. Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Remove envoy bootstrap install from docs Risk Level: low Testing: na Docs Changes: CONTRIBUTING.md Release Notes: [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this issue
Nov 29, 2022
envoyproxy/envoy-mobile#185 Removing the instructions for installing the envoy bootstrap since we will want to have our own. Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Remove envoy bootstrap install from docs Risk Level: low Testing: na Docs Changes: CONTRIBUTING.md Release Notes: [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
|
No longer relevant after the repo merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should create our own bootstrap script rather than use envoy's
The contribution docs specify to use
./envoy/support/bootstrapThis will cause the envoy pre-push scripts (which use the formatting rules defined in envoy) instead of format file we have defined: https://github.com/lyft/envoy-mobile/blob/79dc7346047aa9c3b78d89af2d850ef75a97c0c1/tools/check_format.sh
This causes issues for pushing code because envoy's rules make assumptions that are not valid within envoy-mobile (adding
NOLINTto java files, superfluous declaration of@envoy, etc).The text was updated successfully, but these errors were encountered: