diff --git a/source/common/http/http1/codec_impl.cc b/source/common/http/http1/codec_impl.cc index ceb44446282a..24d9d6d49c3e 100644 --- a/source/common/http/http1/codec_impl.cc +++ b/source/common/http/http1/codec_impl.cc @@ -684,7 +684,7 @@ StreamEncoder& ClientConnectionImpl::newStream(StreamDecoder& response_decoder) return *request_encoder_; } -void ClientConnectionImpl::onEncodeHeaders(const HeaderMapImpl& headers) { +void ClientConnectionImpl::onEncodeHeaders(const HeaderMap& headers) { if (headers.Method()->value() == Headers::get().MethodValues.Head.c_str()) { pending_responses_.back().head_request_ = true; } diff --git a/source/common/http/http1/codec_impl.h b/source/common/http/http1/codec_impl.h index b9b81aae7cfe..6f8cafd2c971 100644 --- a/source/common/http/http1/codec_impl.h +++ b/source/common/http/http1/codec_impl.h @@ -125,7 +125,7 @@ class ConnectionImpl : public virtual Connection, protected Logger::Loggable void { StreamDecoder* decoder = &conn_manager_->newStream(response_encoder_); - HeaderMapPtr headers{new TestHeaderMapImpl{{":authority", "host"}, {":path", "/"}}}; + HeaderMapPtr headers{ + new TestHeaderMapImpl{{":authority", "host"}, {":path", "/"}, {":method", "GET"}}}; decoder->decodeHeaders(std::move(headers), false); Buffer::OwnedImpl fake_data("hello"); @@ -2335,7 +2336,8 @@ TEST_F(HttpConnectionManagerImplTest, FilterAddTrailersInDataCallbackNoTrailers) EXPECT_CALL(*codec_, dispatch(_)).WillOnce(Invoke([&](Buffer::Instance&) -> void { StreamDecoder* decoder = &conn_manager_->newStream(response_encoder_); - HeaderMapPtr headers{new TestHeaderMapImpl{{":authority", "host"}, {":path", "/"}}}; + HeaderMapPtr headers{ + new TestHeaderMapImpl{{":authority", "host"}, {":path", "/"}, {":method", "GET"}}}; decoder->decodeHeaders(std::move(headers), false); Buffer::OwnedImpl fake_data("hello");