Skip to content

Commit

Permalink
docs: Remove envoy bootstrap install from docs (#198)
Browse files Browse the repository at this point in the history
envoyproxy/envoy-mobile#185

Removing the instructions for installing the envoy bootstrap since we will want to have our own.

Signed-off-by: Alan Chiu <achiu@lyft.com>

For an explanation of how to fill out the fields, please see the relevant section
in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md)

Description: Remove envoy bootstrap install from docs
Risk Level: low
Testing: na
Docs Changes: CONTRIBUTING.md
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <jp@jpsim.com>
  • Loading branch information
Alan Chiu authored and jpsim committed Nov 29, 2022
1 parent 37745ff commit c9158e8
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions mobile/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,7 @@ maximize the chances of your PR being merged.
# Submitting a PR

* Fork the repo.
* In your local repo, install the git hooks that implement various important pre-commit and
pre-push checks:

```bash
./envoy/support/bootstrap
```

Please see [envoy/support/README.md](https://github.com/envoyproxy/envoy/tree/master/support) for
more information on these hooks.

Note: the git hooks depend upon many of the dependencies used to build envoy via Bazel. Follow the
[Quick start Bazel build for developers](https://github.com/envoyproxy/envoy/blob/master/bazel/README.md#quick-start-bazel-build-for-developers) guide to install these.

* [[TODO: add bootstrap script for prepush hook](https://github.com/lyft/envoy-mobile/issues/185)]
* Create your PR.
* Tests will automatically run for you.
* We will **not** merge any PR that is not passing tests.
Expand Down

0 comments on commit c9158e8

Please sign in to comment.