[test] De-flake Timer tests #12795
Merged
[test] De-flake Timer tests #12795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oop in order to take advantage of cached monotonic time during timer registration. When the event loop is not running, real monotonic time keeps moving forward which can result in timers ending up with registration times that are the opposite of what's intended by the test and thus result in spurious test failures. Signed-off-by: Antonio Vicente <avd@google.com>
jmarantz
previously approved these changes
Aug 24, 2020
|
clang-tidy needs fix |
Signed-off-by: Antonio Vicente <avd@google.com>
jmarantz
approved these changes
Aug 24, 2020
Should be fixed now. |
|
Existing flake will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
De-flake Timer tests by moving timer registrations inside the event loop in order to take advantage of cached monotonic time during timer registration.
When the event loop is not running, real monotonic time keeps moving forward which can result in timers ending up with registration times that are the opposite of what's intended by the test and thus result in spurious test failures.
Additional Description:
Risk Level: n/a
Testing: No flakes after 30k runs
Docs Changes: n/a
Release Notes: n/a
Fixes #12532