Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quiche: make quic proof source and crypto stream pluggable #16658

Merged
merged 43 commits into from
Jun 10, 2021
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
4570f2d
build no handshake stuff
danzh1989 May 14, 2021
b5821a0
build dispatcher
danzh1989 May 18, 2021
e772105
build listener
danzh1989 May 19, 2021
5a83a9c
making tests pass
danzh1989 May 19, 2021
587facd
revert debug logging
danzh1989 May 19, 2021
108700c
Merge branch 'master' into quiche_fuzz
danzh1989 May 19, 2021
75c569f
add client crypto stream factory
danzh1989 May 24, 2021
547e36b
add proof source factory
danzh1989 May 25, 2021
cef927c
rename some classes
danzh1989 May 25, 2021
d2c7eb5
Merge branch 'master' into quiche_fuzz
danzh1989 May 25, 2021
653a451
Merge branch 'master' into quiche_fuzz
danzh1989 May 25, 2021
150befd
use absl::optional
danzh1989 May 25, 2021
083daee
modify docs
danzh1989 May 27, 2021
55c023c
Merge branch 'master' into quiche_fuzz
danzh1989 May 27, 2021
8b38134
fix extension status
danzh1989 May 27, 2021
22137cc
fix toctree reference
danzh1989 May 27, 2021
563ca96
fix docs cross reference
danzh1989 May 27, 2021
467a808
fix CI
danzh1989 May 27, 2021
755072b
fix clang-tidy
danzh1989 May 27, 2021
4afa433
address comments
danzh1989 Jun 1, 2021
e7532be
fix extension libraries
danzh1989 Jun 1, 2021
f9ae166
Merge branch 'master' into quiche_fuzz
danzh1989 Jun 1, 2021
2ddbd65
fix doc reference
danzh1989 Jun 1, 2021
91ff970
try to fix compile option
danzh1989 Jun 1, 2021
d8aa1c3
remove extension
danzh1989 Jun 2, 2021
ec0302c
remove from extension BUILD
danzh1989 Jun 2, 2021
b7a09c2
Revert "remove from extension BUILD"
danzh1989 Jun 2, 2021
a5d29b1
Revert "remove extension"
danzh1989 Jun 2, 2021
b392d62
another try of fixing compile option build
danzh1989 Jun 2, 2021
db8e0f8
fix extension name
danzh1989 Jun 2, 2021
664c3b8
Merge branch 'master' into quiche_fuzz
danzh1989 Jun 3, 2021
8b89c58
comment
danzh1989 Jun 3, 2021
5512f37
Merge branch 'master' into quiche_fuzz
danzh1989 Jun 3, 2021
522e4f4
Merge branch 'master' into quiche_fuzz
danzh1989 Jun 4, 2021
b352b81
address api comment
danzh1989 Jun 4, 2021
52afe14
move around extensions
danzh1989 Jun 8, 2021
257fd65
fix extension build config
danzh1989 Jun 8, 2021
d2164a0
fix doc reference
danzh1989 Jun 8, 2021
d6f6647
fix crypto_stream doc reference
danzh1989 Jun 8, 2021
0471c5c
Merge branch 'master' into quiche_fuzz
danzh1989 Jun 9, 2021
58441b8
address comments
danzh1989 Jun 9, 2021
9c95845
Merge branch 'master' into quiche_fuzz
danzh1989 Jun 9, 2021
7465ec6
format
danzh1989 Jun 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ extensions/filters/common/original_src @snowp @klarose
# postgres_proxy extension
/*/extensions/filters/network/postgres_proxy @fabriziomello @cpakulski @dio
# quic extension
/*/extensions/quic_listeners/ @alyssawilk @danzh2010 @mattklein123 @mpwarres @wu-bin @ggreenway
/*/extensions/quic/ @alyssawilk @danzh2010 @mattklein123 @mpwarres @wu-bin @ggreenway
# zookeeper_proxy extension
/*/extensions/filters/network/zookeeper_proxy @rgs1 @snowp
# redis cluster extension
Expand Down
2 changes: 2 additions & 0 deletions api/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,8 @@ proto_library(
"//envoy/extensions/matching/common_inputs/environment_variable/v3:pkg",
"//envoy/extensions/matching/input_matchers/consistent_hashing/v3:pkg",
"//envoy/extensions/network/socket_interface/v3:pkg",
"//envoy/extensions/quic/crypto_stream/v3:pkg",
"//envoy/extensions/quic/proof_source/v3:pkg",
"//envoy/extensions/rate_limit_descriptors/expr/v3:pkg",
"//envoy/extensions/request_id/uuid/v3:pkg",
"//envoy/extensions/resource_monitors/fixed_heap/v3:pkg",
Expand Down
14 changes: 13 additions & 1 deletion api/envoy/config/listener/v3/quic_config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ syntax = "proto3";
package envoy.config.listener.v3;

import "envoy/config/core/v3/base.proto";
import "envoy/config/core/v3/extension.proto";
import "envoy/config/core/v3/protocol.proto";

import "google/protobuf/any.proto";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unused - could you remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

import "google/protobuf/duration.proto";
import "google/protobuf/wrappers.proto";

Expand All @@ -20,7 +22,7 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
// [#protodoc-title: QUIC listener config]

// Configuration specific to the UDP QUIC listener.
// [#next-free-field: 6]
// [#next-free-field: 8]
message QuicProtocolOptions {
option (udpa.annotations.versioning).previous_message_type =
"envoy.api.v2.listener.QuicProtocolOptions";
Expand Down Expand Up @@ -48,4 +50,14 @@ message QuicProtocolOptions {
// bound by 6000, regardless of this field or how many connections there are.
google.protobuf.UInt32Value packets_to_read_to_connection_count_ratio = 5
[(validate.rules).uint32 = {gte: 1}];

// Configure which implementation of quic::QuicCryptoClientStreamBase to be used for this listener.
Copy link
Member

@phlax phlax Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you surround quic::QuicCryptoClientStreamBase with `` as its a literal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// If not specified the :ref:`QUICHE default one configured by <envoy_v3_api_msg_extensions.quic.crypto_stream.v3.CryptoServerStreamConfig>` will be used.
// [#extension-category: envoy.quic.server.crypto_stream]
core.v3.TypedExtensionConfig crypto_stream_config = 6;

// Configure which implementation of quic::ProofSource to be used for this listener.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make quic::ProofSource a literal also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// If not specified the :ref:`default one configured by <envoy_v3_api_msg_extensions.quic.proof_source.v3.ProofSourceConfig>` will be used.
// [#extension-category: envoy.quic.proof_source]
core.v3.TypedExtensionConfig proof_source_config = 7;
}
14 changes: 13 additions & 1 deletion api/envoy/config/listener/v4alpha/quic_config.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions api/envoy/extensions/quic/crypto_stream/v3/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py.

load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package")

licenses(["notice"]) # Apache 2

api_proto_package(
deps = ["@com_github_cncf_udpa//udpa/annotations:pkg"],
)
17 changes: 17 additions & 0 deletions api/envoy/extensions/quic/crypto_stream/v3/crypto_stream.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
syntax = "proto3";

package envoy.extensions.quic.crypto_stream.v3;

import "udpa/annotations/status.proto";

option java_package = "io.envoyproxy.envoy.extensions.quic.crypto_stream.v3";
option java_outer_classname = "CryptoStreamProto";
option java_multiple_files = true;
option (udpa.annotations.file_status).package_version_status = ACTIVE;

// [#protodoc-title: QUIC server crypto stream config]
// [#extension: envoy.quic.server.crypto_stream.quiche]

// Configuration for the default QUIC server crypto stream provided by QUICHE.
message CryptoServerStreamConfig {
}
9 changes: 9 additions & 0 deletions api/envoy/extensions/quic/proof_source/v3/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py.

load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package")

licenses(["notice"]) # Apache 2

api_proto_package(
deps = ["@com_github_cncf_udpa//udpa/annotations:pkg"],
)
17 changes: 17 additions & 0 deletions api/envoy/extensions/quic/proof_source/v3/proof_source.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
syntax = "proto3";

package envoy.extensions.quic.proof_source.v3;

import "udpa/annotations/status.proto";

option java_package = "io.envoyproxy.envoy.extensions.quic.proof_source.v3";
option java_outer_classname = "ProofSourceProto";
option java_multiple_files = true;
option (udpa.annotations.file_status).package_version_status = ACTIVE;

// [#protodoc-title: QUIC proof source config]
// [#extension: envoy.quic.proof_source.filter_chain]

// Configuration for the default QUIC proof source.
message ProofSourceConfig {
}
2 changes: 2 additions & 0 deletions api/versioning/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ proto_library(
"//envoy/extensions/matching/common_inputs/environment_variable/v3:pkg",
"//envoy/extensions/matching/input_matchers/consistent_hashing/v3:pkg",
"//envoy/extensions/network/socket_interface/v3:pkg",
"//envoy/extensions/quic/crypto_stream/v3:pkg",
"//envoy/extensions/quic/proof_source/v3:pkg",
"//envoy/extensions/rate_limit_descriptors/expr/v3:pkg",
"//envoy/extensions/request_id/uuid/v3:pkg",
"//envoy/extensions/resource_monitors/fixed_heap/v3:pkg",
Expand Down
1 change: 1 addition & 0 deletions bazel/envoy_library.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def envoy_cc_extension(
)
cc_library(
name = ext_name,
tags = tags,
deps = select({
":is_enabled": [":" + name],
"//conditions:default": [],
Expand Down
1 change: 1 addition & 0 deletions bazel/external/quiche.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2031,6 +2031,7 @@ envoy_cc_library(
external_deps = ["ssl"],
repository = "@envoy",
tags = ["nofips"],
visibility = ["//visibility:public"],
deps = [
":quic_core_crypto_hkdf_lib",
":quic_core_data_lib",
Expand Down
1 change: 1 addition & 0 deletions docs/root/api-v3/config/config.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ Extensions
request_id/request_id
http/header_formatters
http/original_ip_detection
quic/quic_extensions
9 changes: 9 additions & 0 deletions docs/root/api-v3/config/quic/quic_extensions.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Quic Extensions
=================

.. toctree::
:glob:
:maxdepth: 2

../../extensions/quic/crypto_stream/v3/*
../../extensions/quic/proof_source/v3/*
2 changes: 2 additions & 0 deletions generated_api_shadow/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,8 @@ proto_library(
"//envoy/extensions/matching/common_inputs/environment_variable/v3:pkg",
"//envoy/extensions/matching/input_matchers/consistent_hashing/v3:pkg",
"//envoy/extensions/network/socket_interface/v3:pkg",
"//envoy/extensions/quic/crypto_stream/v3:pkg",
"//envoy/extensions/quic/proof_source/v3:pkg",
"//envoy/extensions/rate_limit_descriptors/expr/v3:pkg",
"//envoy/extensions/request_id/uuid/v3:pkg",
"//envoy/extensions/resource_monitors/fixed_heap/v3:pkg",
Expand Down
14 changes: 13 additions & 1 deletion generated_api_shadow/envoy/config/listener/v3/quic_config.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading