-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)" #18192
Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)" #18192
Conversation
bazel/external/googleurl.patch
Outdated
-template <typename T> | ||
-struct __is_cpp17_contiguous_iterator<::gurl_base::CheckedContiguousIterator<T>> | ||
- : true_type {}; | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted. Only difference between #17958
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any more info on this deletion? What impact does it have / are we tracking fixing this upstream somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes it since the android error is trying to specialize something that doesn't exist. I'm surprise this builds at all though, maybe it's just a performance optimization?
Signed-off-by: Alan Chiu <achiu@lyft.com>
3eb179e
to
335210b
Compare
I'm sorry, but I can't understand the purpose of this request unless @mattklein123 's patch is somehow wrong. Duplicate PR asks do not move issues forward but do lead to good contributors being ignored. Could you please explain? |
We can't merge the other PR because it's broken on Android. This is an attempt to fix the Android issue. |
@wrowe @mattklein123 Correct. Envoy Mobile is looking to update the googleurl to avoid an iOS build issue with an xcode update. The main issue with the update is that the method Sorry if I opened this PR prematurely. I was hoping to collaborate more closely with @keith on this issue. He suggested that maybe that method is not necessarily used in Envoy (it builds in Envoy Mobile fwiw). |
Does this change work on Android? Kinda surprised deleting this would work at all, since I assume they had to do this for a reason 🤔 I think the alternative here is you define a no-op struct, maybe only on android, for this. |
I've tested this and this does build with Android in Envoy Mobile. I was hoping to add some |
/retest |
Retrying Azure Pipelines: |
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
This reverts commit 338a42c.
The original PR which this is intending to replicate is: #17794
The original failure which prompted the revert is:
Envoy Slack thread context: https://envoyproxy.slack.com/archives/CKQ2LK23G/p1630533652001900
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]
Signed-off-by: Alan Chiu achiu@lyft.com