bazel: disable wasm on macOS for now #20889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On M1 macs this fails with a linker error that I'm attempting to fix here https://chromium-review.googlesource.com/c/v8/v8/+/3589296 We could also take that as a patch but it would probably be nice to get input upstream on the fix first. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
alecholmez
reviewed
Apr 19, 2022
There was a problem hiding this comment.
@snowp this was super helpful for me building on M1 machines, any interesting in getting this reviewed/merged?
jmarantz
approved these changes
Apr 20, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
On M1 macs this fails with a linker error that I'm attempting to fix here https://chromium-review.googlesource.com/c/v8/v8/+/3589296 We could also take that as a patch but it would probably be nice to get input upstream on the fix first. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
6 tasks
|
@keith should we do |
This was referenced Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On M1 macs this fails with a linker error that I'm attempting to fix
here https://chromium-review.googlesource.com/c/v8/v8/+/3589296
We could also take that as a patch but it would probably be nice to get
input upstream on the fix first.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com