From c585e5331d1b6838c07aa7ca62fe5d39a7795e63 Mon Sep 17 00:00:00 2001 From: Ryan Hamilton Date: Thu, 1 Feb 2024 19:48:44 +0000 Subject: [PATCH 1/3] coverage: lower coverage for source/common/io/ Signed-off-by: Ryan Hamilton --- test/per_file_coverage.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/per_file_coverage.sh b/test/per_file_coverage.sh index 7edf9ee544c5..d232ce7eac02 100755 --- a/test/per_file_coverage.sh +++ b/test/per_file_coverage.sh @@ -11,6 +11,7 @@ declare -a KNOWN_LOW_COVERAGE=( "source/common/event:95.0" # Emulated edge events guards don't report LCOV "source/common/filesystem/posix:96.2" # FileReadToEndNotReadable fails in some env; createPath can't test all failure branches. "source/common/http/http2:95.2" +"source/common/io:57.9 # TODO(#32149): CI has stopped executing this code. "source/common/json:94.6" "source/common/matcher:94.6" "source/common/network:94.4" # Flaky, `activateFileEvents`, `startSecureTransport` and `ioctl`, listener_socket do not always report LCOV From b569237590ccb5c3e8e5325f701dfb37b4ca7661 Mon Sep 17 00:00:00 2001 From: Ryan Hamilton Date: Thu, 1 Feb 2024 20:06:02 +0000 Subject: [PATCH 2/3] Fix Signed-off-by: Ryan Hamilton --- test/per_file_coverage.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/per_file_coverage.sh b/test/per_file_coverage.sh index d232ce7eac02..4b2c20152c37 100755 --- a/test/per_file_coverage.sh +++ b/test/per_file_coverage.sh @@ -11,7 +11,7 @@ declare -a KNOWN_LOW_COVERAGE=( "source/common/event:95.0" # Emulated edge events guards don't report LCOV "source/common/filesystem/posix:96.2" # FileReadToEndNotReadable fails in some env; createPath can't test all failure branches. "source/common/http/http2:95.2" -"source/common/io:57.9 # TODO(#32149): CI has stopped executing this code. +"source/common/io:57.9" # TODO(#32149): CI has stopped executing this code. "source/common/json:94.6" "source/common/matcher:94.6" "source/common/network:94.4" # Flaky, `activateFileEvents`, `startSecureTransport` and `ioctl`, listener_socket do not always report LCOV From 040812929f8cce93bef4055e632c3416988f6c04 Mon Sep 17 00:00:00 2001 From: Ryan Hamilton Date: Thu, 1 Feb 2024 21:49:28 +0000 Subject: [PATCH 3/3] source/common Signed-off-by: Ryan Hamilton --- test/per_file_coverage.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/per_file_coverage.sh b/test/per_file_coverage.sh index 4b2c20152c37..b94220025f8f 100755 --- a/test/per_file_coverage.sh +++ b/test/per_file_coverage.sh @@ -3,7 +3,7 @@ # directory:coverage_percent # for existing directories with low coverage. declare -a KNOWN_LOW_COVERAGE=( -"source/common:96.2" +"source/common:96.0" # TODO(#32149): increase this once io_uring is tested. "source/common/api:84.5" # flaky due to posix: be careful adjusting "source/common/api/posix:83.8" # flaky (accept failover non-deterministic): be careful adjusting "source/common/config:95.4"