Add --managed option to disable timer #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When idle is available, the main purpose of the timer loop is to reconnect the socket when it is disconnected. An alternative is to allow systemd to handle this for us. We can bind the daemon to the mpd service, so that it is started automatically with the mpd service. Add a new command-line option `--managed`. If this is set, the daemon will exit cleanly instead of attempting a reconnect loop, under the assmption that systemd will restart it when mpd is available again.
For that to work I had to remove |
MeisterP
added a commit
to MeisterP/poncho-overlay
that referenced
this pull request
Nov 14, 2024
add support for socket activation Bug: eonpatapon/mpDris2#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When idle is available, the main purpose of the timer loop is to reconnect the
socket when it is disconnected.
An alternative is to allow systemd to handle this for us. We can bind the daemon
to the mpd service, so that it is started automatically with the mpd service.
Add a new command-line option
--managed. If this is set, the daemon will exitcleanly instead of attempting a reconnect loop, under the assmption that systemd
will restart it when mpd is available again.
Fixes #120
Also fixes #160 when managed by systemd - the service is only started when MPD is
Improves #133 when using systemd - the timer is no longer enabled