fixes #722 ? #727
Closed
fixes #722 ? #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 54.73% 54.73%
=======================================
Files 10 10
Lines 1266 1266
=======================================
Hits 693 693
Misses 573 573 ☔ View full report in Codecov by Sentry. |
diegotori
suggested changes
Feb 26, 2024
| @@ -1646,7 +1646,7 @@ $allHashComponents; | |||
|
|
|||
| final newModelMap = allOf.firstWhereOrNull((m) => m.properties.isNotEmpty); | |||
|
|
|||
| final currentProperties = schema.properties; | |||
| final currentProperties = Map.of(schema.properties); | |||
There was a problem hiding this comment.
This could be simplified to:
final currentProperties = {...schema.properties};
|
@Vovanella95 do you have an ETA on when this fix will get released, since we're also running into this issue. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements satotoshitaka11's suggestion