Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System ignores invalid connection point and load canvas instead of throwing an error #2066

Closed
AlexeyGirin opened this issue Jul 3, 2024 · 3 comments · Fixed by #2284
Closed

System ignores invalid connection point and load canvas instead of throwing an error #2066

AlexeyGirin opened this issue Jul 3, 2024 · 3 comments · Fixed by #2284
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Milestone
Indigo-1.24.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load using paste from clipboard IDT type: CHEM1{[A6OH]}|PEPTIDE1{A}$CHEM1,PEPTIDE1,1:R4-1:R1$$$V2.0
    image

Actual behavior
System loads two monomers not connected to each other
image

Expected behavior
System throws exception: Convert error! Given string could not be loaded as (query or plain) molecule or reaction, see the error messages: 'Attachment point (R4) is not found for given monomer ([A6OH]) in given polymer (CHEM1)'
image

Versions

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #1188
@AlexeyGirin AlexeyGirin added Bug Priority: Medium HELM Bucket: Bugs related to Export to HELM format labels Jul 3, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.22.0-rc.2 milestone Jul 3, 2024
@AlexeyGirin AlexeyGirin changed the title System ignores invalid connection point and load canvas instead of throwing an error (CHEM1{[A6OH]}|PEPTIDE1{A}$CHEM1,PEPTIDE1,1:R4-1:R1$$$V2.0) System ignores invalid connection point and load canvas instead of throwing an error Jul 3, 2024
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Jul 9, 2024 that will close this issue
#2064 System establishes connection between monomers even if data is wrong #2094
Merged
8 tasks
@AlexeyGirin
Copy link
Collaborator Author

Not fixed.
No error message appear
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-25; 05:30:25
  • Indigo Toolkit Version 1.23.0-dev.1.14-g284c33a1-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.73 (Official Build) (64-bit)

@AlexeyGirin AlexeyGirin reopened this Aug 1, 2024
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Aug 8, 2024
@AlexeyGirin
Copy link
Collaborator Author

Re-CHECK

@AliaksandrDziarkach AliaksandrDziarkach mentioned this issue Aug 29, 2024
Closed
@AliaksandrDziarkach AliaksandrDziarkach removed a link to a pull request Aug 29, 2024
#2064 System establishes connection between monomers even if data is wrong #2094
Merged
8 tasks
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Aug 30, 2024 that will close this issue
#2120 Export the structure for nucleotides 2-Amino-dA does not work correctly #2284
Merged
7 tasks
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 5, 2024

Tested. Bug fixed.
2024-09-05_15h09_58

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Projects
None yet
Milestone
Indigo-1.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2120 Export the structure for nucleotides 2-Amino-dA does not work correctly epam/Indigo
4 participants
@even1024 @AliaksandrDziarkach @AlexeyGirin @Zhirnoff