Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System loads HELM even if connection point data is wrong #2186

Closed
AlexeyGirin opened this issue Aug 6, 2024 · 3 comments
Closed

System loads HELM even if connection point data is wrong #2186

AlexeyGirin opened this issue Aug 6, 2024 · 3 comments
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Milestone
Indigo-1.24.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load using paste from clipboard IDT type: CHEM1{[A6OH]}|PEPTIDE1{A}$CHEM1,PEPTIDE1,1:R4-1:R1$$$V2.0
    image

Actual behavior
Loads chain without error
image

Expected behavior
Error should occur since A6OH CHEM doesn't have R4 connection point

Versions

  • Ketcher Version 2.23.0-rc.3 Build at 2024-08-01; 05:31:23
  • Indigo Toolkit Version Version 1.23.0-dev.3.2-gb9ac1d93-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

Issue found while testing - #1188
@AlexeyGirin AlexeyGirin added Bug Priority: Medium HELM Bucket: Bugs related to Export to HELM format labels Aug 6, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.24.0-rc.1 milestone Aug 6, 2024
@AlexeyGirin
Copy link
Collaborator Author

Fixed but on review

@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Aug 29, 2024 that will close this issue
#2188 HELM 2 support: variant monomers #2255
Merged
7 tasks
@AliaksandrDziarkach AliaksandrDziarkach removed a link to a pull request Aug 29, 2024
#2188 HELM 2 support: variant monomers #2255
Merged
7 tasks
@AliaksandrDziarkach
Copy link
Collaborator

duplicate of #2066

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 5, 2024

Tested. Bug fixed.
2024-09-05_15h09_58

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Projects
None yet
Milestone
Indigo-1.24.0-rc.1
Development

No branches or pull requests
3 participants
@AliaksandrDziarkach @AlexeyGirin @Zhirnoff