Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message is wrong for wrong ratio number (PEPTIDE1{(A:1.5+C:aaaa)}$$$$V2.0) #2267

Closed
AlexeyGirin opened this issue Aug 29, 2024 · 1 comment · Fixed by #2284
Closed

Error message is wrong for wrong ratio number (PEPTIDE1{(A:1.5+C:aaaa)}$$$$V2.0) #2267

AlexeyGirin opened this issue Aug 29, 2024 · 1 comment · Fixed by #2284
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Milestone
Indigo-1.24.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macromolecules mode
  2. Load using Paste from clipboard way: PEPTIDE1{(A:1.5+C:aaaa)}$$$$V2.0
    image

Actual behavior
Error message is wrong: Convert error! Given string could not be loaded as (query or plain) molecule or reaction, see the error messages: 'SEQUENCE loader: Unexpected symbol e. Expected '+' or ',''
image

Expected behavior
Error message should report that aaa is wrong ratio number

Versions

  • Version 2.24.0-rc.1 Build at 2024-08-28; 15:19:12
  • Indigo Toolkit Version 1.24.0-dev.5.0-g382df81fd-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Found while testing - #2188
@AlexeyGirin AlexeyGirin added Bug Priority: Medium HELM Bucket: Bugs related to Export to HELM format labels Aug 29, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.24.0-rc.1 milestone Aug 29, 2024
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Aug 30, 2024 that will close this issue
#2120 Export the structure for nucleotides 2-Amino-dA does not work correctly #2284
Merged
7 tasks
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Aug 30, 2024
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Projects
None yet
Milestone
Indigo-1.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2120 Export the structure for nucleotides 2-Amino-dA does not work correctly epam/Indigo
2 participants
@AliaksandrDziarkach @AlexeyGirin