Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2064 System establishes connection between monomers even if data is wrong #2094

Merged
merged 1 commit into from
Jul 8, 2024
Merged

#2064 System establishes connection between monomers even if data is wrong #2094

merged 1 commit into from
Jul 8, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Add checks. Add UTs.

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

This was linked to issues Jul 8, 2024
System establishes connection between monomers even if data is wrong #2064
Closed
System connects CHEM and RNA using CHEM and PEPTIDE connection #2076
Closed
@AlexanderSavelyev AlexanderSavelyev merged commit 1d5300c into release/1.22 Jul 8, 2024
74 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2064-helm-connections-check branch July 8, 2024 11:02
This was linked to issues Jul 9, 2024
System ignores invalid connection point and load canvas instead of throwing an error #2066
Closed
Error message on incorrect monomer index could be better #2065
Closed
@AliaksandrDziarkach AliaksandrDziarkach removed a link to an issue Aug 29, 2024
System ignores invalid connection point and load canvas instead of throwing an error #2066
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AliaksandrDziarkach @AlexanderSavelyev