Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2120 Export the structure for nucleotides 2-Amino-dA does not work correctly #2284

Merged
merged 1 commit into from
Aug 30, 2024
Merged

#2120 Export the structure for nucleotides 2-Amino-dA does not work correctly #2284

merged 1 commit into from
Aug 30, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Add code to check connection. Fix error messages. Add UTs.

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@AliaksandrDziarkach
#2120 Export the structure for nucleotides 2-Amino-dA does not work …
3adf623 
…correctly

Add code to check connection. Fix error messages. Add UTs.
This was linked to issues Aug 30, 2024
Export the structure for nucleotides 2-Amino-dA does not work correctly #2120
Closed
Sysmem should throw an error if we try to connect monomer to already occopied attachment point #2078
Closed
System ignores invalid connection point and load canvas instead of throwing an error #2066
Closed
Error message is wrong for wrong ratio number (PEPTIDE1{(A:1.5+C:aaaa)}$$$$V2.0) #2267
Closed
Error message is wrong for wrong base name (RNA1{R(bla-bla-bla)p}$$$$V2.0) #2265
Closed
Error message is wrong for wrong peptide name (PEPTIDE1{D-gGlu}$$$$V2.0) #2264
Closed
Regress: R1-R2 connected unsplit nucleotides saved in FASTA as separate squences #2280
Closed
Error message is wrong for missing ratio number (RNA1{(r(A)p:+r(C)p:200)}$$$$V2.0) #2268
Closed
@AliaksandrDziarkach AliaksandrDziarkach removed a link to an issue Aug 30, 2024
Error message is wrong for missing ratio number (RNA1{(r(A)p:+r(C)p:200)}$$$$V2.0) #2268
Closed
This was linked to issues Aug 30, 2024
Error message is wrong for missing ratio number (RNA1{(r(A)p:+r(C)p:200)}$$$$V2.0) #2268
Closed
Error message is wrong for wrong ratio number (RNA1{(r(A)p:100+r(C)p:aaa)}$$$$V2.0) #2269
Closed
@AlexanderSavelyev AlexanderSavelyev merged commit b2f4a53 into master Aug 30, 2024
74 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2120-nucleotides-goes-in-different-sequence branch August 30, 2024 15:46
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Sep 2, 2024 that may be closed by this pull request
Wrong sequence if sequence with cycle is saved to FASTA or Sequence file #2042
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message is wrong for wrong peptide name (PEPTIDE1{D-gGlu}$$$$V2.0) Export the structure for nucleotides 2-Amino-dA does not work correctly Sysmem should throw an error if we try to connect monomer to already occopied attachment point System ignores invalid connection point and load canvas instead of throwing an error Wrong sequence if sequence with cycle is saved to FASTA or Sequence file
Error message is wrong for wrong base name (RNA1{R(bla-bla-bla)p}$$$$V2.0) Error message is wrong for wrong ratio number (PEPTIDE1{(A:1.5+C:aaaa)}$$$$V2.0) Error message is wrong for missing ratio number (RNA1{(r(A)p:+r(C)p:200)}$$$$V2.0) Error message is wrong for wrong ratio number (RNA1{(r(A)p:100+r(C)p:aaa)}$$$$V2.0) Regress: R1-R2 connected unsplit nucleotides saved in FASTA as separate squences
2 participants
@AliaksandrDziarkach @AlexanderSavelyev