Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment points should be within S-Group brackets #2994

Closed
Ustianskii opened this issue Jul 28, 2023 · 2 comments · Fixed by #3232
Closed

Attachment points should be within S-Group brackets #2994

Ustianskii opened this issue Jul 28, 2023 · 2 comments · Fixed by #3232
Assignees
@StarlaStarla
Labels
bug
Milestone
Ketcher 2.16.0-rc.1

Comments

@Ustianskii
Copy link
Collaborator

Steps to Reproduce

  1. Go to Ketcher
  2. Create structure with S-Group (Multi Group/SRU Polimer)
  3. Add attachment point for the same atom

Actual behaviour
image

Expected behaviour
Attachment points should be inside of S-Group

Ketcher version [e.g. v2.4.2].
Version 2.13.0-rc.2
@Ustianskii Ustianskii added the bug label Jul 28, 2023
@Ustianskii Ustianskii added this to the Ketcher 2.14.0-rc.1 milestone Jul 28, 2023
@Nitvex Nitvex mentioned this issue Jul 28, 2023
Closed
@StarlaStarla StarlaStarla assigned StarlaStarla and unassigned Nitvex Aug 4, 2023
@y-holik
Copy link
Collaborator

y-holik commented Aug 10, 2023

test cases are created

StarlaStarla added a commit that referenced this issue Aug 16, 2023
@StarlaStarla
#2994 Attachment points should be within S-Group brackets
241be24
@StarlaStarla StarlaStarla linked a pull request Aug 16, 2023 that will close this issue
#2994 - Attachment points should be within S-Group brackets #3126
Closed
8 tasks
StarlaStarla added a commit that referenced this issue Aug 17, 2023
@StarlaStarla
#2994 change unit test
d53dc35
StarlaStarla added a commit that referenced this issue Aug 17, 2023
@StarlaStarla
#2994 add autotests
2dde5fb
StarlaStarla added a commit that referenced this issue Aug 17, 2023
@StarlaStarla
#2994 add snapshots
225ba44
StarlaStarla added a commit that referenced this issue Aug 18, 2023
@StarlaStarla
#2994 fix autotests
b0f8a90
StarlaStarla added a commit that referenced this issue Aug 18, 2023
@StarlaStarla
#2994 add snapshots
445ce1a
StarlaStarla added a commit that referenced this issue Aug 18, 2023
@StarlaStarla
#2994 – fix auto tests
4b4900d
StarlaStarla added a commit that referenced this issue Aug 18, 2023
@StarlaStarla
#2994 – fix auto tests
713c76b
StarlaStarla added a commit that referenced this issue Aug 21, 2023
@StarlaStarla
#2994 – fix auto tests
0419589
StarlaStarla added a commit that referenced this issue Aug 22, 2023
@StarlaStarla
#2994 fix autotests
690361e
StarlaStarla added a commit that referenced this issue Aug 23, 2023
@StarlaStarla
#2994 fix autotests
361b6bd
StarlaStarla added a commit that referenced this issue Aug 23, 2023
@StarlaStarla
#2994 fix autotests
cb89f61
StarlaStarla added a commit that referenced this issue Aug 23, 2023
@StarlaStarla
#2994 fix autotests
1360972
StarlaStarla added a commit that referenced this issue Aug 23, 2023
@StarlaStarla
#2994 fix autotests
d3d9fc2
StarlaStarla added a commit that referenced this issue Aug 23, 2023
@StarlaStarla
#2994 fix autotests
d269709
StarlaStarla added a commit that referenced this issue Aug 23, 2023
@StarlaStarla
#2994 resolve conflicts
625cff8
StarlaStarla added a commit that referenced this issue Aug 24, 2023
@StarlaStarla
#2994 fix autotests
ec1e164
StarlaStarla added a commit that referenced this issue Aug 25, 2023
@StarlaStarla
#2994 revert brackets length when there are no attachment points
607535c
StarlaStarla added a commit that referenced this issue Aug 31, 2023
@StarlaStarla
#2994 fix autotests
3c0e43e
StarlaStarla added a commit that referenced this issue Aug 31, 2023
@StarlaStarla
#2994 fix autotests
2337503
StarlaStarla added a commit that referenced this issue Aug 31, 2023
@StarlaStarla
#2994 fix autotests
fbb59f3
Nitvex added a commit that referenced this issue Aug 31, 2023
@Nitvex
#2994 - Attachment points should be within S-Group brackets
ec121dc
StarlaStarla added a commit that referenced this issue Aug 31, 2023
@StarlaStarla
#2994 fix autotests
77ff2a8
StarlaStarla added a commit that referenced this issue Aug 31, 2023
@StarlaStarla
#2994 fix auto tests
cb1d122
@Nitvex Nitvex mentioned this issue Aug 31, 2023
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Aug 31, 2023
@StarlaStarla
#2994 merge enhancement
1259f20
StarlaStarla added a commit that referenced this issue Sep 1, 2023
@StarlaStarla
#2994 fix autotests
8ab4686
StarlaStarla added a commit that referenced this issue Sep 1, 2023
@StarlaStarla
#2994 fix lowerIndexText position issue
274d9e5
StarlaStarla added a commit that referenced this issue Sep 2, 2023
@StarlaStarla
#2994 auto tests
fadf385
StarlaStarla added a commit that referenced this issue Sep 4, 2023
@StarlaStarla
#2994 fix autotests and fusing issue for Benzene, Benzene
40ef2fe
StarlaStarla added a commit that referenced this issue Sep 5, 2023
@StarlaStarla
#2994 fix autotests and lowerindextext position
1f989c3
StarlaStarla added a commit that referenced this issue Sep 5, 2023
@StarlaStarla
#2994 fix autotests
e51c8bc
StarlaStarla added a commit that referenced this issue Sep 5, 2023
@StarlaStarla
#2994 fix upperIndexText position
3137d41
StarlaStarla added a commit that referenced this issue Sep 13, 2023
@StarlaStarla
#2994 fix rgroup label position issue
b5f1f97
StarlaStarla added a commit that referenced this issue Sep 14, 2023
@StarlaStarla
#2994 fix rgroup label position issue
84d8369
StarlaStarla added a commit that referenced this issue Sep 15, 2023
@StarlaStarla
#2994 enhancement
0463786
StarlaStarla added a commit that referenced this issue Sep 15, 2023
@StarlaStarla
#2994 update snapshots
136e184
StarlaStarla added a commit that referenced this issue Sep 15, 2023
@StarlaStarla
#2994 fix for sgroup on more than 2 crossBondsValues
1f732b4
rrodionov91 pushed a commit that referenced this issue Sep 15, 2023
@Nitvex @Zhirnoff @StarlaStarla
#2994 - Attachment points should be within S-Group brackets (#3232)
2495c01 
* #2994 - Attachment points should be within S-Group brackets

---------

Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com>
Co-authored-by: Starla Huang <starla_huang@epam.com>
@ViktoriaTkacheva
Copy link
Collaborator

Preview. Bug is fixed

image

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.16.0-rc.1
6 participants
@StarlaStarla @Nitvex @Ustianskii @KonstantinEpam23 @ViktoriaTkacheva @y-holik