Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: RNA Builder. Delete presets. #3041

Closed
isidoraotasevic opened this issue Aug 4, 2023 · 3 comments · Fixed by #3414 or #3473
Closed

Macro: RNA Builder. Delete presets. #3041

isidoraotasevic opened this issue Aug 4, 2023 · 3 comments · Fixed by #3414 or #3473
Assignees
@StarlaStarla
Labels
feature request Macromolecules [PE] Epic: Monomer Library
Milestone
Macromolecules Mi...

Comments

@isidoraotasevic
Copy link
Collaborator

isidoraotasevic commented Aug 4, 2023 •
edited by rrodionov91
Loading

Background:
This task covers deleting RNA presets in RNA library.

Requirements:

User deletes RNA presets in the following way:
• User hovers over chosen RNA preset in preset section in RNA library.
• With a right click on a mouse, the collapsing panel appears displaying Delete option.
• User clicks on Delete button.
• Once delete button is clicked, the warning message appears: “Are you sure you want to delete RNA preset?”. (TBD with UX)
• Two following options appear: Yes and No.
• User confirms to delete RNA preset by clicking “Yes”.
• RNA preset is removed from RNA library

User chooses not to delete presets from RNA library:
• User confirms not to delete RNA preset by clicking “No”.
• RNA preset stays in RNA library

Inability to delete and edit default RNA presets:
• User can not delete/edit default RNA presets, buttons are disabled

Displaying a star for adding presets to favorites:

  • A star for adding RNA presets to Favorite library shall appear in the upper left corner inside preset framework.

** Figma link
https://www.figma.com/file/MZ28kJRelnXvBodXu54UKh/Macromolecules-(Polymer-Editor)-Playground?type=design&node-id=5149-9013&mode=design&t=1YYvaoEyNpvgCShy-0
@Andrey-Antonov
Copy link
Collaborator

Andrey-Antonov commented Aug 30, 2023 •
edited
Loading

image

@OlZhur OlZhur assigned Andrey-Antonov and unassigned Nitvex Sep 1, 2023
@OlZhur OlZhur added this to the Polymer Editor MVP milestone Sep 1, 2023
@Andrey-Antonov
Copy link
Collaborator

image
context menu positioning

StarlaStarla added a commit that referenced this issue Oct 9, 2023
@StarlaStarla
#3041 Delete RNA presets.
ec7aefc
@StarlaStarla StarlaStarla linked a pull request Oct 9, 2023 that will close this issue
Macro: #3041 – RNA Builder. Delete presets. #3414
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Oct 9, 2023
@StarlaStarla
#3041 fix right click preset
f3599cd
StarlaStarla added a commit that referenced this issue Oct 10, 2023
@StarlaStarla
#3041 fix right click preset
63d20e7
StarlaStarla added a commit that referenced this issue Oct 10, 2023
@StarlaStarla
#3041 fix auto tests
e243fdb
StarlaStarla added a commit that referenced this issue Oct 11, 2023
@StarlaStarla
#3041 remove skip for tests
0421b02
StarlaStarla added a commit that referenced this issue Oct 11, 2023
@StarlaStarla
#3041 fix screenshots
b18423c
Nitvex added a commit that referenced this issue Oct 11, 2023
@Nitvex
#3041 – updated screenshots
2711c70
StarlaStarla added a commit that referenced this issue Oct 12, 2023
@StarlaStarla
#3041 update screenshots
537c5ec
StarlaStarla added a commit that referenced this issue Oct 13, 2023
@StarlaStarla
#3041 update implementation
132a6ab
StarlaStarla added a commit that referenced this issue Oct 13, 2023
@StarlaStarla
#3041 update screenshots
5959683
@Nitvex Nitvex changed the title RNA Builder. Delete presets. Macro: RNA Builder. Delete presets. Oct 13, 2023
StarlaStarla added a commit that referenced this issue Oct 16, 2023
@StarlaStarla
#3041 add dots menu and change delete dialog style
318d946
StarlaStarla added a commit that referenced this issue Oct 16, 2023
@StarlaStarla
#3041 update screenshot
181bca2
StarlaStarla added a commit that referenced this issue Oct 16, 2023
@StarlaStarla
#3041 align modal style
2580368
StarlaStarla added a commit that referenced this issue Oct 16, 2023
@StarlaStarla
#3041 update screenshots
d857fdd
StarlaStarla added a commit that referenced this issue Oct 17, 2023
@StarlaStarla
#3041 update screenshots
2dbc7ea
StarlaStarla added a commit that referenced this issue Oct 17, 2023
@StarlaStarla
#3041 fix ci babel audit issue
fe2dd42
StarlaStarla added a commit that referenced this issue Oct 18, 2023
@StarlaStarla
#3041 update ui design
c077861
StarlaStarla added a commit that referenced this issue Oct 18, 2023
@StarlaStarla
#3041 update screenshots
da3dba4
rrodionov91 pushed a commit that referenced this issue Oct 18, 2023
@StarlaStarla @Nitvex
Macro: #3041 – RNA Builder. Delete presets. (#3414)
b07a313 
* #3041 Delete RNA presets.
* #3041 add dots menu and change delete dialog style
* #3041 align modal style
* #3041 update screenshots

---------

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
StarlaStarla added a commit that referenced this issue Oct 20, 2023
@StarlaStarla
#3041 update menu style & offset
ec3e70c
@StarlaStarla StarlaStarla linked a pull request Oct 20, 2023 that will close this issue
Macro: #3041 – RNA Builder. Delete presets. #3473
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Oct 20, 2023
@StarlaStarla
#3041 update
f3b3723
StarlaStarla added a commit that referenced this issue Oct 23, 2023
@StarlaStarla
#3041 update screenshots
3a6538b
StarlaStarla added a commit that referenced this issue Oct 24, 2023
@StarlaStarla
#3041 update screenshot
7de6549
StarlaStarla added a commit that referenced this issue Oct 24, 2023
@StarlaStarla
#3041 update screenshot
66cbd5c
@MartaWilliams
Copy link
Collaborator

Tested

  • I just couldn't add RNA presets to Favorite library
    2023-10-24_14h07_13
    2023-10-24_14h04_03

@MartaWilliams MartaWilliams mentioned this issue Oct 24, 2023
Closed
StarlaStarla added a commit that referenced this issue Oct 24, 2023
@StarlaStarla
#3041 update screenshot
c84377a
StarlaStarla added a commit that referenced this issue Oct 25, 2023
@StarlaStarla
#3041 update screenshot
3b6a6ff
StarlaStarla added a commit that referenced this issue Nov 3, 2023
@StarlaStarla
#3041 update snapshots
eeee729
StarlaStarla added a commit that referenced this issue Nov 7, 2023
@StarlaStarla
#3041 update screenshots
5c02d60
StarlaStarla added a commit that referenced this issue Nov 9, 2023
@StarlaStarla
#3041 update screeshots
ba4202f
StarlaStarla added a commit that referenced this issue Nov 9, 2023
@StarlaStarla
#3041 update screeshots
5233d64
rrodionov91 pushed a commit that referenced this issue Nov 10, 2023
@StarlaStarla
Macro: #3041 – RNA Builder. Delete presets. (#3473)
80bc156 
- disabled edit for default presets
- fixed context menu position for presets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
feature request Macromolecules [PE] Epic: Monomer Library
Projects
None yet
Milestone
Macromolecules Milestone 1
6 participants
@StarlaStarla @Nitvex @MartaWilliams @OlZhur @isidoraotasevic @Andrey-Antonov