Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ring bond count, degree and atomic mass atom properties #3371

Closed
AlexanderSavelyev opened this issue Sep 27, 2023 · 3 comments · Fixed by #3379
Closed

Merge ring bond count, degree and atomic mass atom properties #3371

AlexanderSavelyev opened this issue Sep 27, 2023 · 3 comments · Fixed by #3379

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Sep 27, 2023

Background
Right now it there are duplicates for the following properties

isotope=atomic mass
ring bond count = ring connectivity
substitution count=degree

Solution

  • Rename Isotope into Isotope (atomic mass)
  • Remove Atomic mass from "Query specific" and use the Isotope (atomic mass) field to load/save and display the atomic mass
  • Remove Degree from "Query specific" and use Substitution count to load/save and display the degree. Display should be sn
  • Increase number of options for Substitution count up to 9
  • Remove Ring connectivity from "Query specific" and use Ring bond count to load/save and display the rings count. Display should be rbn
  • Increase number of options for Ring bond count up to 9
  • Increase all the "Query specific" properties which are drop-down up to 9. The same should be applied for right-click menu as well
@AlexanderSavelyev AlexanderSavelyev added this to the Refined Backlog milestone Sep 27, 2023
@AKZhuk AKZhuk linked a pull request Sep 29, 2023 that will close this issue
9 tasks
AKZhuk added a commit that referenced this issue Sep 29, 2023
Nitvex pushed a commit that referenced this issue Oct 2, 2023
…#3379)

* #3371 - Merge ring bond count, degree and atomic mass atom properties

* #3371 - Merge ring bond count, degree and atomic mass atom properties
- Update e2e snapshots
AnastasiyaPiatrovaKlu pushed a commit that referenced this issue Oct 2, 2023
…#3379)

* #3371 - Merge ring bond count, degree and atomic mass atom properties

* #3371 - Merge ring bond count, degree and atomic mass atom properties
- Update e2e snapshots
@ViktoriaTkacheva
Copy link
Collaborator

The "H count" indicator in the "Query specific" section was increased only to 8, but it needs to be increased to 9 (as specified in the Solution section)

image

@AKZhuk
Copy link
Collaborator

AKZhuk commented Oct 5, 2023

The "H count" indicator in the "Query specific" section was increased only to 8, but it needs to be increased to 9 (as specified in the Solution section)

image

fixed in #3398

@ViktoriaTkacheva
Copy link
Collaborator

The bug is fixed

image

@AKZhuk AKZhuk modified the milestones: Ketcher 2.16.0-rc.1, SMART-Enhancement Oct 18, 2023
@Nitvex Nitvex modified the milestones: SMART Enhancement, Ketcher 2.16.0-rc.1 Oct 23, 2023
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants