Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update customQuery for bonds using topology #3372

Closed
AlexanderSavelyev opened this issue Sep 27, 2023 · 1 comment · Fixed by #3374
Closed

Update customQuery for bonds using topology #3372

AlexanderSavelyev opened this issue Sep 27, 2023 · 1 comment · Fixed by #3374
Assignees
@AKZhuk
Labels
epic: smarts feature request
Milestone
Ketcher 2.16.0-rc.1

Comments

@AlexanderSavelyev
Copy link
Contributor

Background
Custom query for bonds do not take the topology correctly all the time

Solution

  • If topology = "Either" then customQuery should be empty e.g. Type=Single, Topology=Either => customQuery=-
  • If topology = "Ring" then customQuery should be @, e.g. Type=Double, Topology=Ring=>customQuery==;@
  • If topology = "Chain" then customQuery should be !@, e.g. Type=Triple, Topology=Chain=>customQuery==;!@
@AlexanderSavelyev AlexanderSavelyev added this to the Refined Backlog milestone Sep 27, 2023
AKZhuk added a commit that referenced this issue Sep 28, 2023
@AKZhuk
#3372 - Update customQuery for bonds using topology
f0bdfa2
@AKZhuk AKZhuk linked a pull request Sep 28, 2023 that will close this issue
#3372 - Update customQuery for bonds using topology #3374
Merged
9 tasks
Nitvex pushed a commit that referenced this issue Sep 28, 2023
@AKZhuk
#3372 - Update customQuery for bonds using topology (#3374)
e11818d
@ViktoriaTkacheva
Copy link
Collaborator

Preview. No comments

image

@AKZhuk AKZhuk modified the milestones: Ketcher 2.16.0-rc.1, SMART-Enhancement Oct 18, 2023
@Nitvex Nitvex modified the milestones: SMART Enhancement, Ketcher 2.16.0-rc.1 Oct 23, 2023
@urszula-gawlowska urszula-gawlowska mentioned this issue Nov 16, 2023
Closed
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AKZhuk AKZhuk

Labels
epic: smarts feature request
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.16.0-rc.1
Development

Successfully merging a pull request may close this issue.

#3372 - Update customQuery for bonds using topology epam/ketcher
4 participants
@AlexanderSavelyev @AKZhuk @Nitvex @ViktoriaTkacheva