Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3d mol files appear as 2D in Miew #3501

Closed
dondaley opened this issue Oct 25, 2023 · 4 comments · Fixed by #4529
Closed

3d mol files appear as 2D in Miew #3501

dondaley opened this issue Oct 25, 2023 · 4 comments · Fixed by #4529
Assignees
@Nitvex
Labels
bug
Milestone
Ketcher 2.22.0-rc.2

Comments

@dondaley
Copy link

Steps to Reproduce

  1. import 3D mol file'
  2. Click on 3D view
  3. View structure

Actual behavior
3d mol files appear as 2D in Miew
Expected behavior
#D appeared with 3D mol file in previous versions

Screenshots
image

image
image

squashes file into 2D and changes cooridinates
image

and V3000 does not work

Desktop (please complete the following information):

  • OS: Macos 14.0
  • Browser safari
  • Version 17.0

Ketcher version [e.g. v2.4.2].
2.11.0

Test case

Additional context
@dondaley dondaley added the bug label Oct 25, 2023
@mikaukora
Copy link

Based on my testing this happens at d4981dc for the first time.
The commit is included in release/2.18.

Steps to reproduce:

  • Open structure library
  • Select 3D Templates
  • Select fullerene C60 and place it on canvas
  • Select 3D viewer
  • The structure is rendered flat (2d) instead of 3d

mtreinik added a commit to mtreinik/ketcher that referenced this issue Apr 24, 2024
@mtreinik
Fix viewing 3D molecules in Miew (issue epam#3501)
dd46221 
- Rotation was missing z coordinate when switching into chemistry coordinate system.
@mtreinik
Copy link
Contributor

mtreinik commented Apr 24, 2024 •
edited
Loading

The pull request below fixes this issue. The function rotateCoordAxisBy180Degrees was missing z coordinate, thus flattening the molecule to a two-dimensional figure.

@mtreinik mtreinik mentioned this issue Apr 24, 2024
Merged
9 tasks
NataliaLoginova added a commit that referenced this issue Apr 25, 2024
@NataliaLoginova
Merge pull request #4529 from mtreinik/master
0dc44a1 
#3501 3d mol files appear as 2D in Miew
@NataliaLoginova
Copy link
Collaborator

@mtreinik thank you a lot for for fixing the issue #3501!

@rrodionov91 rrodionov91 linked a pull request Apr 26, 2024 that will close this issue
#3501 - 3d mol files appear as 2D in Miew #4529
Merged
9 tasks
@rrodionov91 rrodionov91 added this to the Ketcher 2.22.0-rc.1 milestone Apr 26, 2024
@NadezhdaPeskun
Copy link

Verified as fixed for CI of Ketcher 2.22.rc1.
ketcher (31).zip

@rrodionov91 rrodionov91 mentioned this issue May 17, 2024
Closed
@rrodionov91 rrodionov91 mentioned this issue Jul 25, 2024
Closed
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.22.0-rc.2
Development

Successfully merging a pull request may close this issue.

#3501 - 3d mol files appear as 2D in Miew mtreinik/ketcher
7 participants
@mtreinik @NataliaLoginova @mikaukora @rrodionov91 @dondaley @Nitvex @NadezhdaPeskun