Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: restrict micro and macro structures merging #3630

Closed
rrodionov91 opened this issue Nov 29, 2023 · 2 comments · Fixed by #3641
Closed

Macro: restrict micro and macro structures merging #3630

rrodionov91 opened this issue Nov 29, 2023 · 2 comments · Fixed by #3641
Assignees
@ivan-arkhipov-epam
Labels
bug Priority: Medium
Milestone
Macromolecules Mi...

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Nov 29, 2023 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode
  2. Add monomer on canvas
  3. Go to Molecules mode
  4. Add benzine ring on canvas
  5. Select atom on benzine ring, drag it to monomer and drop

Actual behavior
Monomer disappeared, benzine ring looks ugly.
Video:
https://github.com/epam/ketcher/assets/14859362/6f0ac88c-732e-4cc2-8b28-7b5a161c7dfe

Expected behavior
Merging between macro and micro entities should be ingored.
@rrodionov91 rrodionov91 changed the title Macro: restrict monomer movement in molecules mode Macro: restrict micro and macro structures merging Nov 29, 2023
@rrodionov91 rrodionov91 linked a pull request Dec 1, 2023 that will close this issue
#3630 - Macro: restrict micro and macro structures merging #3641
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 4, 2023
@rrodionov91 @ivan-arkhipov-epam
#3630 - Macro: restrict micro and macro structures merging (#3641)
d91050a 
- added helpers for detecting macromolecules in different cases
- fixed bond dragging restriction between macro and micro entities

---------

Co-authored-by: Ivan Arkhipov <ivan_arkhipov@epam.com>
Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Manual tests added to the table.

This was referenced Dec 21, 2023
Open
Open
@AlexeyGirin
Copy link
Collaborator

Verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-arkhipov-epam ivan-arkhipov-epam

Labels
bug Priority: Medium
Projects
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

#3630 - Macro: restrict micro and macro structures merging epam/ketcher
5 participants
@rrodionov91 @AlexeyGirin @Nitvex @ivan-arkhipov-epam @Zhirnoff