Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: undo/redo does not toggle snake mode #3633

Closed
rrodionov91 opened this issue Nov 29, 2023 · 2 comments · Fixed by #3682
Closed

Macro: undo/redo does not toggle snake mode #3633

rrodionov91 opened this issue Nov 29, 2023 · 2 comments · Fixed by #3682
Assignees
@AlexeyGirin
Labels
bug Priority: Medium
Milestone
Macromolecules Mi...

Comments

@rrodionov91
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode
  2. Add peptide chain on canvas
  3. Click on 'Snake mode' button on left tool panel
  4. Click on 'Undo' button on left tool panel

Actual behavior
Chain position changed on previous one(before snake layout), however snake mode still turned on and bonds drawn as snake ones.

Expected behavior
A clear and concise description of what you expected to happen.
Snake mode turned off and bonds drawn as straight lines.
Nitvex added a commit that referenced this issue Dec 11, 2023
@Nitvex
#3633 – Macro: undo/redo does not toggle snake mode
9b9a5ff
Nitvex added a commit that referenced this issue Dec 11, 2023
@Nitvex
#3633 – added mode layer
a77de05
Nitvex added a commit that referenced this issue Dec 11, 2023
@Nitvex
#3633 – added e2e-tests
d98bf20
@Nitvex Nitvex mentioned this issue Dec 11, 2023
Merged
9 tasks
Nitvex added a commit that referenced this issue Dec 12, 2023
@Nitvex
#3633 – eliminated cicrular dependency
d950b88
rrodionov91 pushed a commit that referenced this issue Dec 12, 2023
@Nitvex
Macro: #3633 – undo/redo does not toggle snake mode (#3682)
7a3657d 
* #3633 – Macro: undo/redo does not toggle snake mode

* #3633 – added mode layer

* #3633 – added e2e-tests

* #3633 – eliminated cicrular dependency
@Zhirnoff
Copy link
Collaborator

Autotests added to the table.

@AlexeyGirin
Copy link
Collaborator

Verified.

@AlexeyGirin AlexeyGirin assigned AlexeyGirin and unassigned Nitvex Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyGirin AlexeyGirin

Labels
bug Priority: Medium
Projects
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

Macro: #3633 – undo/redo does not toggle snake mode epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff