Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Misalignment of monomers when imposing on top of each other #3635

Closed
chgayane opened this issue Nov 30, 2023 · 1 comment · Fixed by #3662
Closed

Macro: Misalignment of monomers when imposing on top of each other #3635

chgayane opened this issue Nov 30, 2023 · 1 comment · Fixed by #3662
Assignees
@chgayane
Labels
bug Priority: High
Milestone
Macromolecules Mi...

Comments

@chgayane
Copy link
Collaborator

Steps to reproduce:

  1. Select two monomers that need to be imposed on top of each other.
  2. Position the first monomer above the second one.
  3. Use the bond tool to aim for the attachment points of the underlying monomer.
  4. Observe the resulting misalignment and scattering of the attachment points.

MicrosoftTeams-image

Actual behavior:
The attachment points of the underlying monomer become scattered, resulting in distorted monomers and misalignment.

Expected behavior:
The attachment points should remain intact, and the monomers should align correctly without scattering or distortion.
@chgayane chgayane added the bug label Nov 30, 2023
@chgayane chgayane added this to the Macromolecules Milestone 3 milestone Nov 30, 2023
@chgayane chgayane assigned Nitvex and chgayane and unassigned Nitvex Nov 30, 2023
@chgayane chgayane changed the title Macro : Misalignment of monomers when imposing on top of each other Macro: Misalignment of monomers when imposing on top of each other Nov 30, 2023
chgayane added a commit that referenced this issue Dec 6, 2023
@chgayane
#3635 - monomers align correctly without scattering or distortion
ecf0a2b
@chgayane chgayane linked a pull request Dec 6, 2023 that will close this issue
Macro: #3635 - Misalignment of monomers when imposing on top of each other #3662
Merged
9 tasks
chgayane added a commit that referenced this issue Dec 7, 2023
@chgayane
#3635 - adding findClosestElementFromPoint function and updating coor…
dbb3fe5 
…dinates order for consistency with the function
chgayane added a commit that referenced this issue Dec 8, 2023
@chgayane
#3635 - correct coordinates order in Vec2.diff calculation
de2b1fb
chgayane added a commit that referenced this issue Dec 8, 2023
@chgayane
#3635 - simplify findClosestElementFromPoint function
a77c8be
chgayane added a commit that referenced this issue Dec 8, 2023
@chgayane
#3635 - updated screenshots
5c21ff7
chgayane added a commit that referenced this issue Dec 8, 2023
@chgayane
#3635 - updated screenshots
5f9b581
chgayane added a commit that referenced this issue Dec 11, 2023
@chgayane
#3635 - Refactor calculation of pointOnBorder length
8065fba
chgayane added a commit that referenced this issue Dec 11, 2023
@chgayane
#3635 - updated screenshots
14243b5
chgayane added a commit that referenced this issue Dec 12, 2023
@chgayane
#3635 - Refactor calculation of pointOnBorder length
cf06799
chgayane added a commit that referenced this issue Dec 12, 2023
@chgayane
#3635 - Improve monomer border point detection logic
d56ae46
chgayane added a commit that referenced this issue Dec 12, 2023
@chgayane
#3635 - updated screenshots
8c90082
chgayane added a commit that referenced this issue Dec 13, 2023
@chgayane
#3635 - Refactor to improve element comparison logic
081bd34
chgayane added a commit that referenced this issue Dec 13, 2023
@chgayane
#3635 - Removing optional chaining from monomer renderer
8e28a64
Nitvex pushed a commit that referenced this issue Dec 13, 2023
@chgayane
Macro: #3635 - Misalignment of monomers when imposing on top of each …
70b6522 
…other (#3662)

* #3635 -  monomers align correctly without scattering or distortion

* #3635 - adding findClosestElementFromPoint function and updating coordinates order for consistency with the  function

* #3635 - correct coordinates order in Vec2.diff calculation

* #3635 - simplify findClosestElementFromPoint function

* #3635 - updated screenshots

* #3635 - updated screenshots

* #3635 - Refactor calculation of pointOnBorder length

* #3635 - updated screenshots

* #3635 - Refactor calculation of pointOnBorder length

* #3635 - Improve monomer border point detection logic

* #3635 - updated screenshots

* #3635 - Refactor to improve element comparison logic

* #3635 - Removing optional chaining from monomer renderer
@Zhirnoff
Copy link
Collaborator

Autotest added to the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
bug Priority: High
Projects
None yet
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

Macro: #3635 - Misalignment of monomers when imposing on top of each other epam/ketcher
5 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff @chgayane