Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: After clicking the 'Duplicate and Edit' button and subsequently clicking 'Cancel,' the preset remains saved. #3663

Closed
Zhirnoff opened this issue Dec 6, 2023 · 2 comments · Fixed by #4249
Closed

Macro: After clicking the 'Duplicate and Edit' button and subsequently clicking 'Cancel,' the preset remains saved. #3663

Zhirnoff opened this issue Dec 6, 2023 · 2 comments · Fixed by #4249
Assignees
@ilya-asiyuk-epam
Labels
bug Macromolecules Priority: Low
Milestone
Ketcher 2.20.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 6, 2023

Steps to Reproduce

  1. Switch to Macromolecule mode
  2. Switch on RNA tab
  3. In Presets section right-click on 'A' and click 'Duplicate and Edit'
  4. Press 'Cancel' in RNA Builder

Actual behavior
After clicking the 'Duplicate and Edit' button and subsequently clicking 'Cancel,' the preset remains saved

Expected behavior
After clicking the 'Duplicate and Edit' button and subsequently clicking 'Cancel,' the preset is not saved

Screenshots

2023-12-06_16h17_43.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.17.0-rc.1
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 4 milestone Dec 6, 2023
@kavalapka kavalapka assigned kavalapka and unassigned rrodionov91 Dec 6, 2023
@kavalapka kavalapka linked a pull request Dec 8, 2023 that will close this issue
Macro: #3663 the preset remains saved after clicking Cancel #3678
Closed
9 tasks
This was referenced Dec 8, 2023
Closed
Closed
@kavalapka kavalapka linked a pull request Dec 8, 2023 that will close this issue
Macro: #3663 the preset remains saved after clicking Cancel #3680
Closed
9 tasks
@kavalapka kavalapka mentioned this issue Dec 8, 2023
Closed
9 tasks
@kavalapka kavalapka linked a pull request Dec 8, 2023 that will close this issue
Macro: #3663 the preset remains saved after clicking Cancel #3681
Closed
9 tasks
@ilya-asiyuk-epam ilya-asiyuk-epam removed a link to a pull request Mar 15, 2024
Macro: #3663 the preset remains saved after clicking Cancel #3678
Closed
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Mar 15, 2024
@ilya-asiyuk-epam
#3663 - Macro: After clicking the 'Duplicate and Edit' button and sub…
5446614 
…sequently clicking 'Cancel,' the preset remains saved.
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Mar 15, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam removed a link to a pull request Mar 15, 2024
Macro: #3663 the preset remains saved after clicking Cancel #3681
Closed
9 tasks
@ilya-asiyuk-epam ilya-asiyuk-epam removed a link to a pull request Mar 15, 2024
Macro: #3663 the preset remains saved after clicking Cancel #3680
Closed
9 tasks
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Mar 15, 2024 that will close this issue
#3663 - Macro: After clicking the 'Duplicate and Edit' button and subsequently clicking 'Cancel,' the preset remains saved. #4249
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Mar 15, 2024
@ilya-asiyuk-epam
#3663 - Macro: After clicking the 'Duplicate and Edit' button and sub…
661a151 
…sequently clicking 'Cancel,' the preset remains saved.
@Zhirnoff
Copy link
Collaborator Author

Test added to the automation table.

rrodionov91 pushed a commit that referenced this issue Mar 15, 2024
@ilya-asiyuk-epam
#3663 - Macro: After clicking the 'Duplicate and Edit' button and sub…
688f2f2 
…sequently clicking 'Cancel,' the preset remains saved. (#4249)
@Zhirnoff
Copy link
Collaborator Author

Tested. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
bug Macromolecules Priority: Low
Projects
None yet
Milestone
Ketcher 2.20.0-rc.1
6 participants
@rrodionov91 @kavalapka @AlexeyGirin @Nitvex @Zhirnoff @ilya-asiyuk-epam