Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro/Micro: Switching from Macromolecules view to Molecules view causes crash if custom aromatic hydrocarbon was connected with monomer #3738

Closed
AlexeyGirin opened this issue Dec 20, 2023 · 1 comment · Fixed by #3811
Closed

Macro/Micro: Switching from Macromolecules view to Molecules view causes crash if custom aromatic hydrocarbon was connected with monomer #3738

AlexeyGirin opened this issue Dec 20, 2023 · 1 comment · Fixed by #3811
Assignees
@rrodionov91
Labels
bug Macromolecules Priority: High
Milestone
Ketcher 2.18.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macromolecules view
  2. Load this file: ConnectionCrash.zip (unzip first)
  3. Connect monomer and aromatic hydrocarbon (use any connection point)
  4. Switch to Molecules view

Actual behavior
System crashes.
Log: polymer.test.lifescience.opensource.epam.com-1703043886622.log
image

Expected behavior
Works as intended

Desktop (please complete the following information):

  • OS: win10
  • Browser Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version [e.g. v2.4.2].
image
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned rrodionov91 and Nitvex Dec 26, 2023
rrodionov91 added a commit that referenced this issue Dec 26, 2023
@rrodionov91
#3738 - Macro/Micro: Switching from Macromolecules view to Molecules …
ca1d301 
…view causes crash if custom aromatic hydrocarbon was connected with monomer

- added ability to bond micro and macro structures in macro mode
@rrodionov91 rrodionov91 linked a pull request Dec 26, 2023 that will close this issue
#3738 - Macro/Micro: Switching from Macromolecules view to Molecules view causes crash if custom aromatic hydrocarbon was connected with monomer #3811
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 28, 2023
@rrodionov91
#3738 - Macro/Micro: Switching from Macromolecules view to Molecules …
10844db 
…view causes crash if custom aromatic hydrocarbon was connected with monomer (#3811)

* #3738 - Macro/Micro: Switching from Macromolecules view to Molecules view causes crash if custom aromatic hydrocarbon was connected with monomer

* added ignoring of attachment points calculating/drawing for micromolecules fragments in macro mode

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@AlexeyGirin
Copy link
Collaborator Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
3 participants
@rrodionov91 @AlexeyGirin @Nitvex