Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Loading from file and than - Undo changes causes exceptions and breakes selection/moving fuctionality #3756

Closed
AlexeyGirin opened this issue Dec 21, 2023 · 2 comments · Fixed by #3822
Closed

Macro: Loading from file and than - Undo changes causes exceptions and breakes selection/moving fuctionality #3756

AlexeyGirin opened this issue Dec 21, 2023 · 2 comments · Fixed by #3822
Assignees
@StarlaStarla
Labels
bug Priority: High
Milestone
Ketcher 2.18.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macromolecules view
  2. Load this file: PeptideEnumeration_One_Two_Three connections3.zip (unzip first)
  3. Load the same file once again
  4. Press Undo button image
  5. Select all elements on the canvas
    image
  6. Try to move selection

Actual behavior
System throws exceptions to console: polymer.test.lifescience.opensource.epam.com-1703157072453.log
Moving functionality is broken
image

Expected behavior
No exception in log, app works as intended

Desktop (please complete the following information):

  • OS: win10
  • Browser Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version [e.g. v2.4.2].
image
StarlaStarla added a commit that referenced this issue Dec 28, 2023
@StarlaStarla
#3756 Undo changes causes exceptions and breakes selection/moving fu…
460dc73 
…ctionality
@StarlaStarla StarlaStarla linked a pull request Dec 28, 2023 that will close this issue
#3756 - Macro: Loading from file and than - Undo changes causes exceptions and breakes selection/moving fuctionality #3817
Closed
9 tasks
rrodionov91 added a commit that referenced this issue Dec 28, 2023
@rrodionov91
#3756 - Macro: Loading from file and than - Undo changes causes excep…
5230177 
…tions and breakes selection/moving fuctionality

- fixed DrawingEntitiesManager merge method to collect return command
- fixed history setting after opening file to store command for the main DrawingEntitiesManager
@rrodionov91 rrodionov91 linked a pull request Dec 28, 2023 that will close this issue
Macro: #3756 - Loading from file and than - Undo changes causes exceptions and breakes selection/moving fuctionality #3822
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 29, 2023
@rrodionov91
Macro: #3756 - Loading from file and than - Undo changes causes excep…
a6753dc 
…tions and breakes selection/moving fuctionality (#3822)

- fixed DrawingEntitiesManager merge method to collect return command
- fixed history setting after opening file to store command for the main DrawingEntitiesManager

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 5, 2024

Test added to automation table.

@AlexeyGirin
Copy link
Collaborator Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
5 participants
@rrodionov91 @AlexeyGirin @StarlaStarla @Nitvex @Zhirnoff