Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Connection works wrong #3786

Closed
AlexeyGirin opened this issue Dec 23, 2023 · 2 comments · Fixed by #3831
Closed

Macro: Connection works wrong #3786

AlexeyGirin opened this issue Dec 23, 2023 · 2 comments · Fixed by #3831
Assignees
@StarlaStarla
Labels
bug Macromolecules Priority: Medium
Milestone
Ketcher 2.18.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macromolecules view
  2. Load this file: CanNotConnect.zip (unzip first)
  3. Try to connect 5A6 sugar monomer with Rsp using center-to-center way

Actual behavior
System doesn't connect but rises Select Connection Points dialog with missing connection points labels
image

Expected behavior
System establishes connection without rising Connection Points dialog (R1 to R2)

Desktop (please complete the following information):

  • OS: win10
  • Browser Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version [e.g. v2.4.2].
image
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned rrodionov91 and Nitvex Dec 26, 2023
@StarlaStarla StarlaStarla self-assigned this Jan 3, 2024
StarlaStarla added a commit that referenced this issue Jan 4, 2024
@StarlaStarla
#3786 fix getting valid attachment point logic for sugar
d9896d4
StarlaStarla added a commit that referenced this issue Jan 4, 2024
@StarlaStarla
#3786 add tests
ccc107d
@StarlaStarla StarlaStarla linked a pull request Jan 4, 2024 that will close this issue
Macro: #3786 - Connection works wrong #3831
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jan 4, 2024
@StarlaStarla
Macro: #3786 - Connection works wrong (#3831)
6fb6b22 
- fix getting valid attachment point logic for sugar
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 4, 2024

Test added to automation table.

@Zhirnoff
Copy link
Collaborator

Tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug Macromolecules Priority: Medium
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
Development

Successfully merging a pull request may close this issue.

Macro: #3786 - Connection works wrong epam/ketcher
5 participants
@rrodionov91 @AlexeyGirin @StarlaStarla @Nitvex @Zhirnoff