Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: System allow to connect block to already occupied connection (that cases invalid saved files) #3787

Closed
AlexeyGirin opened this issue Dec 24, 2023 · 1 comment · Fixed by #3803
Closed

Macro: System allow to connect block to already occupied connection (that cases invalid saved files) #3787

AlexeyGirin opened this issue Dec 24, 2023 · 1 comment · Fixed by #3803
Assignees
@rrodionov91
Labels
bug Macromolecules Priority: High
Milestone
Ketcher 2.18.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 24, 2023 •
edited
Loading

Steps to Reproduce

  1. Switch to Macromolecules view
  2. Load this file: repro3.zip
  3. Establish connection from "(R2) - Right only" to (R1, R2,R3) using center-to-connection(R2) way
    R1 connection of (R1, R2,R3) remain unoccupied - this is ok.
  4. Establish connection from "(R1) - Left only" to (R1, R2,R3) using center-to-center way
2023-12-24_10h08_58.mp4

Actual behavior
R1 connection remain unoccupied. Since that moment if you export canvas to ket file - it will be invalid
image

Expected behavior
System establishes R1-R1 connection between "(R2) - Left only" and (R1, R2,R3)

Desktop (please complete the following information):

  • OS: win10
  • Browser Chrome 120.0.6099.130 (Official Build) (64-bit)

Ketcher version [e.g. v2.4.2].
image

Documentation
https://kb.epam.com/display/EPMLSOP/Types+of+connections
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned rrodionov91 and Nitvex Dec 26, 2023
rrodionov91 added a commit that referenced this issue Dec 26, 2023
@rrodionov91
#3787 - Macro: System allow to connect block to already occupied conn…
6c94884 
…ection (that cases invalide saved files)

- fixed cleaning potential attachment points in monomers
@rrodionov91 rrodionov91 linked a pull request Dec 26, 2023 that will close this issue
#3787 - Macro: System allow to connect block to already occupied connection (that cases invalide saved files) #3803
Merged
9 tasks
@rrodionov91 rrodionov91 self-assigned this Dec 26, 2023
rrodionov91 added a commit that referenced this issue Dec 26, 2023
@rrodionov91
#3787 - Macro: System allow to connect block to already occupied conn…
be67130 
…ection (that cases invalide saved files) (#3803)

- fixed cleaning potential attachment points in monomers

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@AlexeyGirin AlexeyGirin changed the title Macro: System allow to connect block to already occupied connection (that cases invalide saved files) Macro: System allow to connect block to already occupied connection (that cases invalid saved files) Dec 31, 2023
@AlexeyGirin
Copy link
Collaborator Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
3 participants
@rrodionov91 @AlexeyGirin @Nitvex