Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit hydrogens feature changes layout of simple molecules #3893

Closed
AlexeyGirin opened this issue Jan 15, 2024 · 2 comments · Fixed by #4133 or #4139
Closed

Remove explicit hydrogens feature changes layout of simple molecules #3893

AlexeyGirin opened this issue Jan 15, 2024 · 2 comments · Fixed by #4133 or #4139
Assignees
@captain2b
Labels
bug Priority: Medium query features phase II
Milestone
Ketcher 2.19.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jan 15, 2024 •
edited
Loading

Steps to Reproduce

  1. Load from file: ToTheCenter.zip (unzip first)
  2. Press Add/Remove explicit hydrogens button
    image

Actual behavior
System moves molecules to the center
image

Expected behavior
Molecules should remain in place

Issue found while testing epam/Indigo#1436

Desktop (please complete the following information):

  • OS: Win10
  • Browser Chrome Version 120.0.6099.130 (Official Build) (64-bit)

Ketcher version [e.g. v2.4.2].
Ketcher Version 2.18.0+dev.1 Build at 2024-01-11; 13:21:50
Indigo Toolkit Version 1.18.0-dev.4+1452.0-gaf1efce67-x86_64-linux-gnu-11.4.0
@AlexeyGirin AlexeyGirin added this to the Query Features - Phase II milestone Jan 15, 2024
@AlexeyGirin AlexeyGirin mentioned this issue Jan 22, 2024
Closed
35 tasks
@AlexeyGirin
Copy link
Collaborator Author

Low priority
If no time for fix - move to 2.19

rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
#3893 - Remove explicit hydrogens feature changes layout of simple mo…
3b4774e 
…lecules

- removed rescale if there is no bonds
@rrodionov91 rrodionov91 linked a pull request Feb 22, 2024 that will close this issue
#3893 - Remove explicit hydrogens feature changes layout of simple molecules #4133
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
#3893 - Remove explicit hydrogens feature changes layout of simple mo…
e571d2d 
…lecules (#4133)

- removed rescale if there is no bonds
- fixed screenshots

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
#3893 - Remove explicit hydrogens feature changes layout of simple mo…
ac7fef7 
…lecules

- removed rescale if there is no bonds
@rrodionov91 rrodionov91 linked a pull request Feb 23, 2024 that will close this issue
Backmerge: #3893 - Remove explicit hydrogens feature changes layout of simple molecules #4139
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
Backmerge: #3893 - Remove explicit hydrogens feature changes layout o…
715af96 
…f simple molecules (#4139)

- removed rescale if there is no bonds
- fixed screenshots

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Tested. Fixed.
2024-03-11_17h48_47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@captain2b captain2b

Labels
bug Priority: Medium query features phase II
Projects
None yet
Milestone
Ketcher 2.19.0-rc.2
4 participants
@captain2b @rrodionov91 @AlexeyGirin @Zhirnoff