Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom Query feature export: System lost MOST "Substitution count" values - export to Molfile #3957

Closed
AlexeyGirin opened this issue Jan 24, 2024 · 1 comment · Fixed by #4269

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jan 24, 2024

Environment details (please complete the following information):

Describe the bug
System lost MOST "Substitution count" values

Steps to Reproduce

  1. Open from file: Substitution count.zip
  2. Save it to Molfile file format
  3. Clear canvas
  4. Load from Molfile file format

Actual behavior
System losts most "Substitution count" features
image

Expected behavior
System doesn't lost "Substitution count" features
image

Note
problem is in v2000.js only first occurrence are set

        if (!props.get('substitutionCount')) {
          props.set(
            'substitutionCount',
            sGroup.readKeyValuePairs(propertyData),
          );
        }
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.19.0-rc.1 milestone Jan 24, 2024
@AlexeyGirin AlexeyGirin assigned captain2b and unassigned Nitvex Feb 8, 2024
@rrodionov91 rrodionov91 assigned tmrr13 and unassigned captain2b Mar 5, 2024
tmrr13 added a commit that referenced this issue Mar 11, 2024
tmrr13 added a commit that referenced this issue Mar 11, 2024
tmrr13 added a commit that referenced this issue Mar 11, 2024
tmrr13 added a commit that referenced this issue Mar 11, 2024
tmrr13 added a commit that referenced this issue Mar 11, 2024
tmrr13 added a commit that referenced this issue Mar 18, 2024
tmrr13 added a commit that referenced this issue Mar 19, 2024
tmrr13 added a commit that referenced this issue Mar 19, 2024
NataliaLoginova added a commit that referenced this issue Apr 3, 2024
…tem-lost-most-substitution-count-values-export-to-molfile

#3957 - Atom Query feature export System lost MOST Substitution count values export to Molfile
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

Windows 10
Chrome Version Version 123.0.6312.106 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Toolkit Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment