Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right-click menu appears away from structure or is not visible at all on canvas #4048

Closed
Zhirnoff opened this issue Feb 7, 2024 · 0 comments · Fixed by #4062 or #4067
Closed

Right-click menu appears away from structure or is not visible at all on canvas #4048

Zhirnoff opened this issue Feb 7, 2024 · 0 comments · Fixed by #4062 or #4067
Assignees
@rrodionov91
Labels
bug Priority: High
Milestone
Ketcher 2.18.0-rc.5

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 7, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Ketcher folder->example->src->App.tsx
  2. Add style like on screenshot <div style={{width: '800px', height: '600px', left: '500px', top: '300px', position: 'relative'}}>
  3. Build Ketcher and try use right-click menu

Actual behavior
Right-click menu appears away from structure or is not visible at all on canvas
MicrosoftTeams-image (10)

Expected behavior
Right-click menu appears under mouse cursor like on mockups
2024-02-07_16h46_42
2024-02-07_16h46_50

Screenshots
MicrosoftTeams-image (9)

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.4]

#186985277
@Zhirnoff Zhirnoff added this to the Ketcher 2.18.0-rc.5 milestone Feb 7, 2024
rrodionov91 added a commit that referenced this issue Feb 8, 2024
@rrodionov91
#4048 - Right-click menu appears away from structure or is not visibl…
f96dca7 
…e at all on canvas #4048

- added rendering of context menus out of element with container-type: size
- added moving context menu if it does not fit ketcher editor root element
@rrodionov91 rrodionov91 linked a pull request Feb 8, 2024 that will close this issue
#4048 - Right-click menu appears away from structure or is not visible at all on canvas #4062
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 8, 2024
@rrodionov91
#4048 - Right-click menu appears away from structure or is not visibl…
af78c0b 
…e at all on canvas #4048

- added rendering of context menus out of element with container-type: size
- added moving context menu if it does not fit ketcher editor root element
rrodionov91 added a commit that referenced this issue Feb 9, 2024
@rrodionov91
#4048 - Right-click menu appears away from structure or is not visibl…
6022471 
…e at all on canvas (#4062)

* #4048 - Right-click menu appears away from structure or is not visible at all on canvas #4048

- added rendering of context menus out of element with container-type: size
- added moving context menu if it does not fit ketcher editor root element

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Feb 9, 2024
@rrodionov91
#4048 - Right-click menu appears away from structure or is not visibl…
a6c1cf2 
…e at all on canvas #4048

- added rendering of context menus out of element with container-type: size
- added moving context menu if it does not fit ketcher editor root element
@rrodionov91 rrodionov91 linked a pull request Feb 9, 2024 that will close this issue
Backmerge: #4048 - Right-click menu appears away from structure or is not visible at all on canvas #4067
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 9, 2024
@rrodionov91
Backmerge: #4048 - Right-click menu appears away from structure or is…
24a6a48 
… not visible at all on canvas (#4067)

- added rendering of context menus out of element with container-type: size
- added moving context menu if it does not fit ketcher editor root element
---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@rrodionov91 rrodionov91 mentioned this issue Feb 15, 2024
Closed
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.18.0-rc.5
2 participants
@rrodionov91 @Zhirnoff