-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right-click context menu protrudes beyond edges of the Ketcher workspace #4069
Comments
@Andrey-Antonov to propose the solution |
11 tasks
11 tasks
NataliaLoginova
pushed a commit
that referenced
this issue
Jul 31, 2024
… workspace (#5182) * feat: add new logic for modal windows * feat:changed some of the functional logic * feat: change style in toggleButtonGroup * feat: add styles and logic for context menu * feat: update test * - fixed context menu position calculation from ketcher window instead of document * - removed timeout * - updated screenshots --------- Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Still need to correct the design |
Created a new bug for сorrect the design => #5202 |
Tested. Bug fixed. But design will be implemented in scope of issue #5202 2024-08-07_17h12_33.mp4Desktop:
Ketcher version |
Guch1g0v
pushed a commit
that referenced
this issue
Oct 17, 2024
… workspace (#5182) * feat: add new logic for modal windows * feat:changed some of the functional logic * feat: change style in toggleButtonGroup * feat: add styles and logic for context menu * feat: update test * - fixed context menu position calculation from ketcher window instead of document * - removed timeout * - updated screenshots --------- Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to Reproduce
Case1
Point at atom or bond near structure located at edge and right-click and then, without removing the menu, right-click again on the structure located at edge (select closest atom or bond to the edge of canvas)
Case2
Open developer console and move it closer to boundaries of the Ketcher. Call right-click menu on structure closest to edge (look attached video)
Actual behavior
Right-click context menu protrudes beyond edges of the Ketcher workspace.
Alignment of letters and numbers in pop-up windows is also broken
Note: This problem appears only in the built-in Ketcher(iFrame). On test benches, the algorithm takes into account the distance to the edge of canvas and draws a third menu depending on distance to edge of canvas.
Expected behavior
The right-click context menu does not protrude beyond the edges of Ketcher workspace.
Also, after discussion with @vanoprenko @AlexeyGirin @Andrey-Antonov , we came to the conclusion that the third menu requires a redesign. The design will be developed by @Andrey-Antonov (TBD) and provided here.
Screenshots
2024-02-09_19h19_48.mp4
Desktop (please complete the following information):
Ketcher version
[Version 2.18.0-rc.5]
#187864465
Updated visuals:
The text was updated successfully, but these errors were encountered: