Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand tool coordinates on canvas calculated are not correct #4255

Closed
Zhirnoff opened this issue Mar 15, 2024 · 1 comment · Fixed by #4289, #4324 or #4331
Closed

Hand tool coordinates on canvas calculated are not correct #4255

Zhirnoff opened this issue Mar 15, 2024 · 1 comment · Fixed by #4289, #4324 or #4331

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add Benzene ring on canvas
  3. Select 'Hand tool' move to atoms and bonds of Benzene ring

Actual behavior
Hand tool coordinates on canvas calculated are not correct. When approaching canvas, Hand tool immediately jumps to center and when aimed at atoms or bonds of Benzene ring, does not highlight them. It highlight them when moving on canvas a little further than Benzene ring.

Expected behavior
Hand tool coordinates on canvas calculated are correct. Not jumps to center of canvas and when aimed at atoms or bonds of Benzene ring highlight them.

Screenshots

2024-03-15_16h50_57.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.19.0-rc.1]

@Zhirnoff Zhirnoff added this to the Waiting for triage milestone Mar 15, 2024
@DzhafarOFF DzhafarOFF linked a pull request Mar 20, 2024 that will close this issue
9 tasks
rrodionov91 pushed a commit that referenced this issue Mar 22, 2024
…4289)

* apply custom icons for hand tool, remove unnessary logic
* replace url path with base64 encoded svg
* update failing snapshot

---------

Co-authored-by: Ruslan Dzhafarov <ruslan_dzhafarov@epam.com>
rrodionov91 pushed a commit that referenced this issue Mar 22, 2024
…orrect backmerge (#4324)

* apply custom icons for hand tool, remove unnessary logic
* replace url path with base64 encoded svg
* update failing snapshot

---------

Co-authored-by: Ruslan Dzhafarov <ruslan_dzhafarov@epam.com>
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug is fixed.

ilya-asiyuk-epam added a commit that referenced this issue Mar 27, 2024
…as-calculated-are-not-correct-backmerge

Backmerge: #4255 hand tool coordinates on canvas calculated are not correct backmerge
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment