Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: RNA builder should be highlighted in Edit mode. Canvas should be disabled. #4374

Closed
olganaz opened this issue Mar 29, 2024 · 1 comment · Fixed by #4435
Closed

Macro: RNA builder should be highlighted in Edit mode. Canvas should be disabled. #4374

olganaz opened this issue Mar 29, 2024 · 1 comment · Fixed by #4435
Assignees
@olganaz @ilya-asiyuk-epam
Labels
Epic: Sequence representation feature request
Milestone
Ketcher 2.21.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Mar 29, 2024 •
edited by vanoprenko
Loading

Background
When user starts modifying a group nucleotides on canvas using RNA-builder, they should see a clear indication of specific editing mode (different from regular modification of presets in the monomer library) and that other editing operations on canvas are disabled while group editing is in progress.

Requirements

  1. Once RNA builder switches to Edit mode (See #3824 ), the RNA builder iteslf and the selection being edited should be highlighted with a specific color (see mockups).
  2. All monomers on canvas except those being modified should be grayed/faded out to reflect disabled state.
  3. Selection and right-click menu operations on canvas should be disabled while editing is in progress.

UX
image
image
@olganaz olganaz added this to the Ketcher 2.22.0-rc.1 milestone Mar 29, 2024
@olganaz olganaz self-assigned this Mar 29, 2024
@olganaz olganaz changed the title Macro: Verification of monomer attachment points availability while adding it to RNA-builder Macro: RNA builder should be highlighted in Edit mode. Canvas should be disabled. Mar 29, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam mentioned this issue Apr 2, 2024
Closed
@olganaz olganaz removed the draft label Apr 3, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Apr 8, 2024
ilya-asiyuk-epam added a commit that referenced this issue Apr 8, 2024
@ilya-asiyuk-epam
#4374 - Macro: RNA builder should be highlighted in Edit mode. Canvas…
39e070d 
… should be disabled.
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Apr 8, 2024 that will close this issue
#4374 - Macro: RNA builder should be highlighted in Edit mode. Canvas should be disabled #4435
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Apr 9, 2024
@ilya-asiyuk-epam
#4374 - Macro: RNA builder should be highlighted in Edit mode. Canvas…
2dbeedd 
… should be disabled.
rrodionov91 pushed a commit that referenced this issue Apr 9, 2024
@ilya-asiyuk-epam @rrodionov91
#4374 - Macro: RNA builder should be highlighted in Edit mode. Canvas…
db20638 
… should be disabled.
rrodionov91 added a commit that referenced this issue Apr 10, 2024
@ilya-asiyuk-epam @rrodionov91
#4374 - Macro: RNA builder should be highlighted in Edit mode. Canvas…
670ef26 
… should be disabled (#4435)

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
This was referenced Apr 16, 2024
Closed
Open
Closed
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Apr 16, 2024 •
edited
Loading

Verified.
image

Versions:
Windows 10
Chrome Version 123.0.6312.123 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Toolkit Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olganaz olganaz

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
Epic: Sequence representation feature request
Projects
None yet
Milestone
Ketcher 2.21.0-rc.1
3 participants
@AlexeyGirin @olganaz @ilya-asiyuk-epam